Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Copying logs file #113

Merged
merged 2 commits into from
Apr 9, 2024
Merged

Conversation

tharapalanivel
Copy link
Collaborator

@tharapalanivel tharapalanivel commented Apr 9, 2024

Description of the change

Bug fix to copy over the training logs file after file was renamed recently.

Related issue number

How to verify the PR

Built image locally, ran tuning job and verified training_logs.jsonl existed in specified output_dir

Was the PR tested

  • I have added >=1 unit test(s) for every new method I have added.
  • I have ensured all unit tests pass

Signed-off-by: Thara Palanivel <[email protected]>
Signed-off-by: Thara Palanivel <[email protected]>
Copy link
Collaborator

@Ssukriti Ssukriti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@Ssukriti Ssukriti merged commit 115eacf into foundation-model-stack:main Apr 9, 2024
3 checks passed
@tharapalanivel tharapalanivel deleted the logs_fix branch April 10, 2024 01:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants