Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support logging a LaTeXString #2894

Merged
merged 1 commit into from
Apr 15, 2024
Merged

Support logging a LaTeXString #2894

merged 1 commit into from
Apr 15, 2024

Conversation

fonsp
Copy link
Owner

@fonsp fonsp commented Apr 15, 2024

No description provided.

@fonsp fonsp added the display & PlutoRunner & AbstractPlutoDingetjes.jl label Apr 15, 2024
@fonsp fonsp merged commit 8e6412a into main Apr 15, 2024
@fonsp fonsp deleted the log-LaTeXString branch April 15, 2024 14:38
@github-actions GitHub Actions
Copy link
Contributor

Try this Pull Request!

Open Julia and type:

julia> import Pkg
julia> Pkg.activate(temp=true)
julia> Pkg.add(url="https://github.com/fonsp/Pluto.jl", rev="log-LaTeXString")
julia> using Pluto

@Pangoraw
Copy link
Collaborator

Pangoraw commented May 3, 2024

This change reminded me of #2222 😄 If I recall correctly ProgressLogging has its own string type and format output is slow for it (#2203)?

@fonsp
Copy link
Owner Author

fonsp commented May 6, 2024

Derp!

fonsp added a commit that referenced this pull request May 7, 2024
@fonsp
Revert "Support logging a LaTeXString (#2894)"
86692f4 
This reverts commit 8e6412a.
@fonsp
Copy link
Owner Author

fonsp commented May 7, 2024

Reverted in 86692f4

@fonsp fonsp mentioned this pull request May 8, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
display & PlutoRunner & AbstractPlutoDingetjes.jl
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fonsp @Pangoraw