Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ProgressLogging progress bar has large overhead #2203

Closed
yha opened this issue Jul 6, 2022 · 2 comments · Fixed by #2222
Closed

ProgressLogging progress bar has large overhead #2203

yha opened this issue Jul 6, 2022 · 2 comments · Fixed by #2222
Labels
bug Something isn't working logging About `@info`, `@warn`, etc performance

Comments

@yha
Copy link
Contributor

yha commented Jul 6, 2022

Using ProgressLogging.@progress inside Pluto causes a large overhead that scales roughly with the number of iterations.
In this very simple notebook, it's about 0.05 seconds per iteration. In my actual use case, I observed an overhead of about 0.2 seconds per iteration (which happens to be longer than the computation itself).
https://gist.github.com/yha/9874d03c15175e4075bab565f3730b80

out.mp4
@Pangoraw Pangoraw added the logging About `@info`, `@warn`, etc label Jul 7, 2022
@Pangoraw
Copy link
Collaborator

Pangoraw commented Jul 23, 2022

Thanks for reporting! It will be fixed in the next release

@fonsp fonsp reopened this May 6, 2024
@fonsp fonsp added bug Something isn't working performance labels May 6, 2024
@fonsp
Copy link
Owner

fonsp commented May 8, 2024

#2894 was reverted so this is fixed again

@fonsp fonsp closed this as completed May 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working logging About `@info`, `@warn`, etc performance
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants