Test_data added for #4764 #1764
Conversation
Signed-off-by: 10sharmashivam <[email protected]>
10sharmashivam
force-pushed
the
po_tests_broken
branch
from
02067ac
to
c4003df
Compare
Signed-off-by: 10sharmashivam <[email protected]>
|
@10sharmashivam this is great! does the example work for you in your local cluster? |
Hi @davidmirror-ops! Yes, the example worked correctly for me. I temporarily hosted the biostats.csv file using a local HTTP server, which allowed me to access the CSV file via a localhost URL. I used this URL as the csv_url input to test the CSV normalization, addressing the issue with the broken external link in the parent issue. It produced the expected output—a normalized CSV file—so everything worked perfectly. |
|
Hi @davidmirror-ops, I wanted to check in to see if there’s anything else I can provide for this PR. Please let me know if there are any other tests or adjustments needed. Thanks! |
Tracking issue
Reference Issue
Reference PR - In which adding .csv files allowed
Why are the changes needed?
These changes help and keep test_data on flyteorg/flytesnacks repo, which can work as internal source for test data
Once this PR is approved and merged, I will use the raw github user content link of these test data, and use to correct the broken tests.