Broken PO tests corrected #1766
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: 10sharmashivam <[email protected]>
davidmirror-ops
approved these changes
Oct 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tracking issue
Closes #4764
Referecen Merged PR
Why are the changes needed?
Since Tests were broken because of relying on external sources for test data, but once my earlier PR, got merged, in which I hosted testing datasets locally, I used their raw github user link to replace external source links. Which increases robustness of these tests. @davidmirror-ops
What changes were proposed in this pull request?
Replaced external testing datasets link with internal raw github user links.
How was this patch tested?
All tests using new links works fine, and gives expected output
Check all the applicable boxes