-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add code format and type checker to CI #16
Conversation
a63382f
to
6c8b04f
Compare
.github/workflows/elixir.yml
Outdated
- uses: actions/cache@v1 | ||
with: | ||
path: _build | ||
key: build-${{ hashFiles('mix.lock') }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great! there is a catching as well. or else it could take forever 👍
But I wonder, should we just specify a single key to share the caching to all builds?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@teerawat1992
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, i think we can na 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
According to the recommendation, i'll cache with elixir+eralng version instead 🙇
https://github.com/jeremyjh/dialyxir#continuous-integration
18663bc
to
82e6e90
Compare
#4
ref: https://elixirforum.com/t/caching-dialyzer-output-with-github-actions/27648