Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add code format and type checker to CI #16

Closed
wants to merge 5 commits into from

Conversation

tteerawat
Copy link
Contributor

@tteerawat tteerawat commented Mar 16, 2020

@tteerawat tteerawat force-pushed the setup-dialyxir-for-CI branch from a63382f to 6c8b04f Compare March 16, 2020 09:04
- uses: actions/cache@v1
with:
path: _build
key: build-${{ hashFiles('mix.lock') }}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! there is a catching as well. or else it could take forever 👍

But I wonder, should we just specify a single key to share the caching to all builds?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@teerawat1992

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, i think we can na 👍

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

According to the recommendation, i'll cache with elixir+eralng version instead 🙇
https://github.com/jeremyjh/dialyxir#continuous-integration

@tteerawat tteerawat force-pushed the setup-dialyxir-for-CI branch from 18663bc to 82e6e90 Compare March 26, 2020 15:04
@tteerawat tteerawat closed this Mar 27, 2020
@tteerawat tteerawat reopened this Mar 27, 2020
@tteerawat tteerawat closed this Mar 27, 2020
@tteerawat tteerawat deleted the setup-dialyxir-for-CI branch March 27, 2020 06:07
@tteerawat tteerawat restored the setup-dialyxir-for-CI branch March 27, 2020 06:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants