Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Fixed keyboard navigation in the address path bar #16653

Merged
merged 2 commits into from
Dec 31, 2024
Merged

Conversation

yaira2
Copy link
Member

@yaira2 yaira2 commented Dec 23, 2024

Resolved / Related Issues

To prevent extra work, all changes to the Files codebase must link to an approved issue marked as Ready to build. Please insert the issue number following the hashtag with the issue number that this Pull Request resolves.

Steps used to test these changes

Stability is a top priority for Files and all changes are required to go through testing before being merged into the repo. Please include a list of steps that you used to test this PR.

  1. Pressing the Tab key when the Refresh button (or Home button) is focused will switch the focus to the breadcrumb bar and enable edit mode.
  2. Pressing the Tab key again will turn off edit mode and allow navigation within the breadcrumb bar.

@0x5bfa
Copy link
Member

0x5bfa commented Dec 27, 2024

Can you use nameof(HomeButton) and nameof(Refresh) instead.

@yaira2 yaira2 requested a review from 0x5bfa December 30, 2024 15:52
@yaira2 yaira2 merged commit 84a35eb into main Dec 31, 2024
8 checks passed
@yaira2 yaira2 deleted the ya/PathBar branch December 31, 2024 15:31
@yaira2 yaira2 added the ready to merge Pull requests that are approved and ready to merge label Dec 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready to merge Pull requests that are approved and ready to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: Can't enter edit mode on path bar using the keyboard
2 participants