Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: Can't enter edit mode on path bar using the keyboard #7077

Closed
Hefaistos68 opened this issue Nov 25, 2021 · 11 comments · Fixed by #16653
Closed

Bug: Can't enter edit mode on path bar using the keyboard #7077

Hefaistos68 opened this issue Nov 25, 2021 · 11 comments · Fixed by #16653
Labels
area - omnibar Features or bug reports relating to the omnibar good first issue Good issue for new contributors to get started with

Comments

@Hefaistos68
Copy link

Description

Its seems not possible to enter edit mode in the navigation bar when using only keyboard. Since the focus jumps to a bread crump and from there between other crumps and other controls, there is no way to actually edit the location.
I expected F2 to work, or having a stop at an extra edit field after the crumps, but nope. nothing of the likes.

To be fair, explorer doesnt seem to offer this either, but at least in explorer i can select folders from the bread crumps.

Steps To Reproduce

Use the tab key to jump between the controls in the app until you reach the navigation bar and the bread crumps.

Expected behavior

Some way to edit the location in the navigation bar with keyboard only.

Files Version

Version: 2.0.34.0

Windows Version

OS Version: 10.0.19042.1348

Relevant Assets

No response

@gave92
Copy link
Member

gave92 commented Nov 25, 2021

To enter edit mode "using keyboard" you can use Ctrl+L or Ald+D. But it is an accessibility issue.

@Hefaistos68
Copy link
Author

Damn it, didnt know about the Ctrl+L and Alt+D, works just fine with these shortcuts.

@gave92
Copy link
Member

gave92 commented Nov 25, 2021

Np, same shortcuts work in explorer and web browsers too. Still I think all controls should be reachable by Tabbing (is that right?)

@yaira2
Copy link
Member

yaira2 commented Nov 25, 2021

Np, same shortcuts work in explorer and web browsers too. Still I think all controls should be reachable by Tabbing (is that right @yaichenbaum?)

@gave92 yes, I'm not quite sure how we can handle this scenario but it's something to look into.

@Hefaistos68
Copy link
Author

While at it, check why the bread crumps dont open with key down.

@yaira2
Copy link
Member

yaira2 commented Nov 25, 2021

While at it, check why the bread crumps dont open with key down.

@Hefaistos68 can you open a feature request for that?

@Hefaistos68
Copy link
Author

#7086 opened

@Raithlin
Copy link
Contributor

Raithlin commented Dec 2, 2021

Is there an accepted shortcut we can assign to this? (F2, Esc etc.) I can do the pull request for this if we decide on that.

@yaira2 yaira2 self-assigned this Dec 2, 2021
@yaira2 yaira2 removed their assignment Jan 4, 2022
@yaira2 yaira2 added the good first issue Good issue for new contributors to get started with label Jan 4, 2022
@Josh65-2201 Josh65-2201 moved this to 🆕 New in Files task board Sep 8, 2022
@yaira2 yaira2 changed the title Cant enter edit mode in Navigationbar without mouse Bug: Can't enter edit mode on path bar using the keyboard Oct 25, 2023
@yaira2 yaira2 moved this from 🆕 New to 📋 Planning stage in Files task board Oct 25, 2023
@Raithlin
Copy link
Contributor

The convention is for Tab to move from one control to the next. Perhaps using Enter (or perhaps Shift+Enter) to edit instead?

@yaira2
Copy link
Member

yaira2 commented Oct 29, 2023

The edit box is the next control, but it's hidden when edit mode is turned off and we need to handle it manually. That's why I think it's okay to use tab in this scenario. Shift + enter would work, but would be harder to discover.

@yaira2 yaira2 added the area - omnibar Features or bug reports relating to the omnibar label Aug 18, 2024
@yaira2 yaira2 removed the bug label Oct 7, 2024
@yaira2
Copy link
Member

yaira2 commented Dec 23, 2024

I've opened a pull request to resolve this issue #16653.

@yaira2 yaira2 moved this from 📋 Planning stage to 🏗 In progress in Files task board Dec 23, 2024
@github-project-automation github-project-automation bot moved this from 🏗 In progress to ✅ Done in Files task board Dec 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area - omnibar Features or bug reports relating to the omnibar good first issue Good issue for new contributors to get started with
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

4 participants