Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add RTL Support to TimeSelector Component #131

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add RTL Support to TimeSelector Component #131

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/components/TimeSelector.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import React, { useCallback } from 'react';
import { Text, View, StyleSheet } from 'react-native';
import { Text, View, StyleSheet, I18nManager } from 'react-native';
import { useCalendarContext } from '../CalendarContext';
import Wheel from './TimePicker/Wheel';
import { CALENDAR_HEIGHT } from '../enums';
Expand Down Expand Up @@ -69,7 +69,7 @@ const styles = StyleSheet.create({
flex: 1,
},
timePickerContainer: {
flexDirection: 'row',
flexDirection: I18nManager.getConstants().isRTL ? 'row-reverse' : 'row',
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of row-reverse, it should apply the direction: "rtl" to the parent probably.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It doesn't change the direction of the component

alignItems: 'center',
justifyContent: 'center',
width: CALENDAR_HEIGHT / 2,
Expand Down