Add RTL Support to TimeSelector Component
#131
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
neriyaco
changed the title
TimeSelector Component
| @@ -69,7 +69,7 @@ const styles = StyleSheet.create({ | |||
| flex: 1, | |||
| }, | |||
| timePickerContainer: { | |||
| flexDirection: 'row', | |||
| flexDirection: I18nManager.getConstants().isRTL ? 'row-reverse' : 'row', | |||
There was a problem hiding this comment.
Instead of row-reverse, it should apply the direction: "rtl" to the parent probably.
There was a problem hiding this comment.
It doesn't change the direction of the component
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add RTL Support to
TimeSelectorComponentDescription
This PR introduces support for right-to-left (RTL) layouts in the
TimeSelectorcomponent of the library. TheflexDirectionof thetimePickerContainerstyle now dynamically adapts based on the current RTL setting, ensuring proper alignment for RTL users.Changes
I18nManagerfromreact-native.timePickerContainerstyle to setflexDirectiondynamically:row-reversefor RTL layouts.rowfor LTR layouts.Benefits
Testing
I18nManager.forceRTL(true)) and LTR modes.Breaking Changes