Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update(tests/falco): cover new skip-if-unknown-filter semantics #22

Merged
merged 1 commit into from
Aug 31, 2023

Conversation

jasondellaluce
Copy link
Collaborator

Follow-up to falcosecurity/falco#2749 for increasing coverage on the improved semantics of skip-if-unknown-filter.

Copy link
Member

@Andreagit97 Andreagit97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@poiana
Copy link

poiana commented Aug 31, 2023

LGTM label has been added.

Git tree hash: 9a1ef4a355fd72d4194860d560ca0b0e052c2ba7

@poiana
Copy link

poiana commented Aug 31, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Andreagit97, jasondellaluce

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [Andreagit97,jasondellaluce]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@poiana poiana merged commit b39c807 into main Aug 31, 2023
1 check failed
@poiana poiana deleted the update/upgrade-unknown-filter-warn branch August 31, 2023 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants