update(userspace/engine): improve skip-if-unknown-filter YAML field #2749
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jason Dellaluce <[email protected]>
Signed-off-by: Jason Dellaluce <[email protected]>
|
/milestone 0.36.0 |
|
LGTM label has been added. Git tree hash: 993dbe6a5e746d9509c3a0a4eb1841ba46dd8499
|
|
Requires falcosecurity/testing#22 to be merged to have tests passing. |
Signed-off-by: Jason Dellaluce <[email protected]>
|
LGTM label has been added. Git tree hash: e221a43ee07dfc44cd5e0b11d1163c4e6ef010c7
|
leogr
approved these changes
Aug 31, 2023
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: FedeDP, jasondellaluce, leogr The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind bug
/kind feature
Any specific area of the project related to this PR?
/area engine
What this PR does / why we need it:
The
skip-if-unknown-filterYAML field can be used in Falco rules for skipping a rules if it fails compilation due to an unknown filter field. This PR proposes enlarging its scope to also missing fields in rules' outputs (a bug, currently), and also checking for unknown event types (which can occur more frequently, now that plugins can define new value ofevt.typewith async events). The idea is forskip-if-unknown-filterto skip rules if "there's something unknown in a rule's filter", with the output being included for parity as it uses the same fields available for rules' filters.A follow-up PR adding tests is falcosecurity/testing#22.
Which issue(s) this PR fixes:
Special notes for your reviewer:
Does this PR introduce a user-facing change?: