Skip to content

Commit

Permalink
remove side panel gating
Browse files Browse the repository at this point in the history
Summary:
Now that we've rolled the V1 out and everyone with this feature should see the panel (panel is an essential part of the UX now and I don't think we'll roll it back). I'm removing the 'devFeature' gating for it. I'm keeping the enableDevFeature flag in code so we can later reuse to gate any non-ready features.

Also, refactoring the conditional instanitiation to outside of the the constructor while I'm at it. I think it's cleaner this way.

Differential Revision: D66968009

fbshipit-source-id: f0c4acd6a1f920d3fb96c7194c42940cace3e28f
  • Loading branch information
Larry Lai authored and facebook-github-bot committed Dec 9, 2024
1 parent 1739d2c commit 7dd10d6
Showing 1 changed file with 3 additions and 1 deletion.
4 changes: 3 additions & 1 deletion addons/vscode/extension/extension.ts
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,9 @@ export async function activate(context: vscode.ExtensionContext) {
ctx,
enabledSCMApiFeatures.has('comments-v1'),
);
context.subscriptions.push(inlineCommentsProvider);
if (inlineCommentsProvider != null) {
context.subscriptions.push(inlineCommentsProvider);
}
}
if (Internal.SaplingISLUriHandler != null) {
context.subscriptions.push(
Expand Down

0 comments on commit 7dd10d6

Please sign in to comment.