Skip to content

Commit

Permalink
add more logging
Browse files Browse the repository at this point in the history
Summary:
Add more logging:
1. Add funnel event logging on accept/discard (yes we also log it on the server side but doesn't hurt to log it here as well - fwiw the diff page also logs this from the client side)
2. Add logging for the open comments panel comment
3. Add logging for the jump to and expand inline comment function

Differential Revision: D66930283

fbshipit-source-id: 259fbbf24e7b8d6542e8cbfaa9caf2fcd87b1d11
  • Loading branch information
Larry Lai authored and facebook-github-bot committed Dec 9, 2024
1 parent c7594cd commit 1739d2c
Showing 1 changed file with 2 additions and 0 deletions.
2 changes: 2 additions & 0 deletions addons/isl-server/src/analytics/eventNames.ts
Original file line number Diff line number Diff line change
Expand Up @@ -135,11 +135,13 @@ export type TrackEventName =
| 'UncommitOperation'
| 'JfSubmitOperation'
| 'JfGetOperation'
| 'JumpToInlineComment'
| 'OptimisticFilesStateForceResolved'
| 'OptimisticCommitsStateForceResolved'
| 'OptimisticConflictsStateForceResolved'
| 'OptInToNewISLAgain'
| 'OpenAllFiles'
| 'OpenComments'
| 'QueueOperation'
| 'QueueCancelledWarningShown'
| 'RecoverCommitMessageFromOperationError'
Expand Down

0 comments on commit 1739d2c

Please sign in to comment.