Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: added subscription handling through annotations #2

Merged
merged 5 commits into from
Dec 12, 2024
Merged

refactor: added subscription handling through annotations #2

merged 5 commits into from
Dec 12, 2024

Conversation

dwimberger
Copy link
Contributor

No description provided.

axi92
axi92 requested changes Dec 10, 2024
View reviewed changes
Copy link
Member

@axi92 axi92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add the tests in a github workflow, like here and enable a check for the test in the rules (protect-main rule)

axi92
axi92 requested changes Dec 11, 2024
View reviewed changes
.github/workflows/build.yml Outdated Show resolved Hide resolved
@dwimberger
Copy link
Contributor Author

Please add the tests in a github workflow, like here and enable a check for the test in the rules (protect-main rule)

Both done.

@dwimberger dwimberger closed this Dec 11, 2024
@dwimberger dwimberger reopened this Dec 11, 2024
@dwimberger dwimberger requested a review from axi92 December 11, 2024 20:32
@axi92 axi92 requested a review from 0x7061 December 12, 2024 13:58
@dwimberger dwimberger merged commit 1388a0a into main Dec 12, 2024
13 checks passed
@dwimberger dwimberger deleted the feature/annotation-handling-e2e-test branch December 12, 2024 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0x7061 0x7061 0x7061 approved these changes

@axi92 axi92 axi92 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dwimberger @axi92 @0x7061