Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

submitting packages: Form URL list & Surrounds #87

Closed
wants to merge 2 commits into from

Conversation

mistahBen
Copy link

A package that users can create their own custom lists of URLS (or almost any text, really) and use one expansion to choose the link they want to expand.

A package that users can create their own custom lists of URLS (or almost any text, really) and use one expansion to choose the link they want to expand.
A package that uses regex with triggers to surround text in various braces, brackets or other characters.
Copy link
Collaborator

@smeech smeech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Form-list is a nice package, that reads its data from a .CSV file.
The package name needs changing to form-list (without the capital letter).

surrounds is incomplete, unfortunately.

Copy link
Collaborator

@smeech smeech May 6, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some tags: and a homepage: item would make merging into the hub more reliable. See Espanso Hub for examples.

Copy link
Collaborator

@smeech smeech May 6, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some tags: and a homepage: item would make merging into the hub more reliable. See Espanso Hub for examples.

Copy link
Collaborator

@smeech smeech May 6, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This appears to be missing the global_vars: code to extract the clipboard contents into the {{paste_word}} variable.

@smeech smeech added the invalid This doesn't seem right label May 6, 2024
@smeech
Copy link
Collaborator

smeech commented Jun 15, 2024

Also needs version numbers in the directory paths.

@mistahBen - if you would kindly attend to these issues, I think the package could be merged soon afterwards. If you consider it abandoned, please let us know, and we'll decide whether to fix it ourselves or delete the PR.

if you need any help, please let me know.

@smeech smeech changed the title submitting package: Form URL list submitting packages: Form URL list & Surrounds Jul 24, 2024
smeech added a commit to smeech/hub that referenced this pull request Dec 13, 2024
Much amended version of part of the failed PR espanso#87.
It's been over a year since the original submission and I have been unable to get a response from @mistahBen, even going as far as submitting a PR mistahBen#1 to his own repo.
I like this package as it illustrates a useful technique, so I think it's worth preserving.
Thanks to @mistahBen for the idea!
@smeech smeech mentioned this pull request Dec 13, 2024
@smeech
Copy link
Collaborator

smeech commented Dec 13, 2024

Closed in favour of #143. See details there.

All credit to @mistahBen, for the idea.

@smeech smeech closed this Dec 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
invalid This doesn't seem right
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants