Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Form URL list #143

Merged
merged 6 commits into from
Dec 13, 2024
Merged

Form URL list #143

merged 6 commits into from
Dec 13, 2024

Conversation

smeech
Copy link
Collaborator

@smeech smeech commented Dec 13, 2024

Much amended version of part of the failed PR #87.
It's been over a year since the original submission and I have been unable to get a response from @mistahBen, even going as far as submitting a PR mistahBen#1 to his own repo, with corrected code.
I like this package as it illustrates a useful technique, so I think it's worth preserving.
I'll close #87.
Thanks to @mistahBen for the idea!

Much amended version of part of the failed PR espanso#87.
It's been over a year since the original submission and I have been unable to get a response from @mistahBen, even going as far as submitting a PR mistahBen#1 to his own repo.
I like this package as it illustrates a useful technique, so I think it's worth preserving.
Thanks to @mistahBen for the idea!
@AucaCoyan
Copy link
Member

Looks good! I didn't tried in my pc though

@smeech smeech merged commit 08770c8 into espanso:main Dec 13, 2024
1 check passed
@smeech
Copy link
Collaborator Author

smeech commented Dec 13, 2024

Made a minor mistake, which prevents the package working. #144 merged, but I think the Hub isn't picking up the change.
May need @arabello's help, I'm afraid. 😞

I am happy to simply submit a new version for the update (probably should have done that in the first place).

@smeech
Copy link
Collaborator Author

smeech commented Dec 14, 2024

Fixed via #145.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants