feat: create queues and topics #61
Conversation
* chore: update required Azure provider version Support for the `network_rule_set` block for resource `azurerm_servicebus_namespace` was added in Azure provider v3.71. * refactor: rename variables * refactor: remove variable for enabling network rules * refactor: remove duplicate variable * Fix configuration of Premium only features * Deny public network access by default * Dynamically configure network rules default action * Rename variable * Set optional object property * Reorder blocks
|
Are these resources actually essential (as they are described in equinor/terraform-baseline#177), or does it make more sense for these resources to be created outside of this module? I think a good comparison would be our Azure Storage module which creates only the Storage account; containers, file shares, tables and queues must be created outside of the module. |
|
without a queue or a Topic resource you only have a halfway completed resource that as far as i know can not be used for anything. You need at least 1 queue or 1 topic to forward messages to. But it might still be preferable to keep it outside?! |
|
Suggestion: create queues, but not authorization rules, since authorization rules promote the use of access keys instead of RBAC. If authorization rules are needed, create outside of module. |
…us into service-bus-queue
musifalsk
changed the title
hknutsen
changed the title
|
Updated PR title. |
Co-authored-by: Henrik Simonsen Knutsen <[email protected]>
Co-authored-by: Henrik Simonsen Knutsen <[email protected]>
hknutsen
dismissed
their stale review
Changes implemented in separate commit.
No description provided.