forked from RedaOps/ann-visualizer
-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Merge remote-tracking branch 'kushaangupta/feature/tensorflow-2-support'
From RedaOps#36 Fixes RedaOps#25 Fixes RedaOps#34 Fixes RedaOps#35
- Loading branch information
Showing
1 changed file
with
27 additions
and
21 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3a80ab6
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
From RedaOps#36
Actually this doesn't really fix RedaOps#25 RedaOps#34 or RedaOps#35 as @kushaangupta claimed in pull request RedaOps#36?
Those issues are all about Input layers, not about tensorflow versions? Input layers are actually fixed in ff773b1 ?
3a80ab6
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh you're right! I assumed that the error they got was due to the same reason that I was having. I should've taken a look at the seed code. I guess it's better to point people to your fork rather than mine. Thanks for pointing it out
3a80ab6
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kushaangupta Yeah I'm trying to collect all the different forks as much as possible and get this working again
3a80ab6
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These tensorflow changes were also submitted as RedaOps#31 by @aliakbarhamzeh1378 , but that fork no longer exists