-
-
Notifications
You must be signed in to change notification settings - Fork 289
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: added custom image resolver #253
Open
slaveeks
wants to merge
17
commits into
master
Choose a base branch
from
feat/custom-download
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 16 commits
Commits
Show all changes
17 commits
Select commit
Hold shift + click to select a range
c7303e1
feat: added custom downloader
slaveeks fa0d4c9
fix: eslint
slaveeks c30e4c6
Apply suggestions from code review
slaveeks 4f6544b
downloader -> imageResolver
slaveeks e26aa80
fix: eslint
slaveeks 532b312
change readme
slaveeks 9ee60d7
fix: rednme
slaveeks 35e9d63
fix: imageResolver docs
slaveeks 19652a3
fix: fix comment
slaveeks c2f3d1b
fix comment
slaveeks e8da2c3
fix: fixed doc
slaveeks 19388f7
Apply suggestions from code review
slaveeks e9a655d
Apply suggestions from code review
slaveeks 0be89a4
review changes
slaveeks 2c9a2f7
update readme
slaveeks 1e0b52f
updated docs
slaveeks f603c1a
update fileData desc
slaveeks File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,52 @@ | ||
import isPromise from './utils/isPromise'; | ||
|
||
/** | ||
* Module for file image resolving. Handle case, when you have to use custom image resolving method | ||
*/ | ||
export default class ImageResolver { | ||
/** | ||
* @param {object} params - image resolver module params | ||
* @param {ImageConfig} params.config - image tool config | ||
* @param {Function} params.onError - callback for resolving errors | ||
*/ | ||
constructor({ config, onResolve, onError }) { | ||
this.config = config; | ||
this.onError = onError; | ||
} | ||
|
||
/** | ||
* Try to resolve image url by file data and fill it using stored data | ||
* | ||
* @param {any} fileData - file data, from which file url need to be resolved | ||
*/ | ||
async resolveUrlByFileData(fileData) { | ||
/** | ||
* Check that custom url resolver passed | ||
*/ | ||
if (this.config.imageResolver && typeof this.config.imageResolver.resolveUrlByFileData === 'function') { | ||
const resolveFileData = this.config.imageResolver.resolveUrlByFileData(fileData); | ||
|
||
if (!isPromise(resolveFileData)) { | ||
console.warn('Custom downloader method download should return a Promise'); | ||
} | ||
|
||
try { | ||
/** | ||
* Return resolver url | ||
*/ | ||
return await resolveFileData; | ||
} catch (error) { | ||
this.onError(error); | ||
} | ||
} else { | ||
/** | ||
* If there is no custom resolve method, fileData must have correct url property, which have no need in resolving | ||
*/ | ||
if (!fileData.url) { | ||
this.onError('Incorrect data: file data should contain url'); | ||
} | ||
|
||
return fileData.url; | ||
} | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -176,4 +176,3 @@ export default class Uploader { | |
}); | ||
} | ||
} | ||
|
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is it an any data returned from the server?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
updated desc