Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: added custom image resolver #253

Open
wants to merge 17 commits into
base: master
Choose a base branch
from
Open

Conversation

slaveeks
Copy link

@slaveeks slaveeks commented Jul 4, 2024

  1. Added ImageResolver module for working with custom downloading
  2. Added imageResolver field to config, which stores download method for custom downloading
  3. Added inResolve method to use data, which is returned after downloading

@slaveeks slaveeks requested a review from neSpecc July 4, 2024 16:32
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
src/downloader.js Outdated Show resolved Hide resolved
src/downloader.js Outdated Show resolved Hide resolved
src/downloader.js Outdated Show resolved Hide resolved
@slaveeks slaveeks requested a review from neSpecc July 4, 2024 19:58
@slaveeks slaveeks changed the title feat: added custom downloader feat: added custom image resolver Jul 4, 2024
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
src/imageResolver.js Outdated Show resolved Hide resolved
src/index.js Outdated Show resolved Hide resolved
@slaveeks slaveeks requested a review from neSpecc July 5, 2024 00:27
README.md Outdated
| -------------- | --------- | ------------- | ------------|
| resolveUrlByFileData | `fileData`| `Promise.<string>` | Resolve image url by file data |

`fileData` - any data, which is needed for resolving url
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is it an any data returned from the server?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated desc

@slaveeks slaveeks requested a review from neSpecc July 5, 2024 00:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants