fix(bucket_storage): image deletion #764
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
Pull Request Test Coverage Report for Build 178a825f94ef3323a6e601faf29eeec76de0bbaa-PR-764Details
💛 - Coveralls |
|
PR is fine. Could we add a line of change to CHANGELOG.md? |
noaccOS
force-pushed
the
push-nuslyxmlmoou
branch
from
68f29ab to
171b105
Compare
lusergit
approved these changes
Dec 9, 2024
previously, calling Ash.destroy! on a base image would crash the program because Edgehog.BaseImages.Uploaders.BaseImage.filename/2 would try to access the field `base_image_version` of a BaseImage, which does not exist Signed-off-by: Francesco Noacco <[email protected]>
noaccOS
force-pushed
the
push-nuslyxmlmoou
branch
from
171b105 to
178a825
Compare
davidebriani
approved these changes
Dec 9, 2024
davidebriani
merged commit 5517c6e
into
edgehog-device-manager:release-0.9
8 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
previously, calling Ash.destroy! on a base image would crash the program because Edgehog.BaseImages.Uploaders.BaseImage.filename/2 would try to access the field
base_image_versionof a BaseImage, which does not exist