feat: azure support #613
Merged
feat: azure support #613
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build ed8f2f75dcbdc53f01633d70396ac929ff4d4b0e-PR-613Details
💛 - Coveralls |
Pull Request Test Coverage Report for Build a7116681ef8baefe2232c24de76888c5218d59a8-PR-613Details
💛 - Coveralls |
rbino
requested changes
Oct 11, 2024
noaccOS
force-pushed
the
feat/azure
branch
11 times, most recently
from
81e9f1c to
6242cec
Compare
lusergit
approved these changes
Dec 5, 2024
davidebriani
requested changes
Dec 9, 2024
Comment on lines
45
to
58
| def delete(%BaseImage{} = base_image) do | ||
| %BaseImage{ | ||
| url: url, | ||
| tenant_id: tenant_id, | ||
| version: base_image_version, | ||
| base_image_collection_id: base_image_collection_id | ||
| } = base_image | ||
|
|
||
| scope = %{ | ||
| tenant_id: tenant_id, | ||
| base_image_collection_id: base_image_collection_id, | ||
| base_image_version: base_image_version | ||
| } | ||
|
|
There was a problem hiding this comment.
This was broken from previous releases.
It would be nice to have this fix in v0.9 and forward-port it to main.
add runtime s3 configuration for the test environment as well as prod. this is needed during CI but should not affect normal use Signed-off-by: Francesco Noacco <[email protected]>
davidebriani
requested changes
Dec 19, 2024
CHANGELOG.md
Outdated
| @@ -7,6 +7,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0 | |||
| ## [0.10] - Unreleased | |||
| ### Added | |||
| - Managed OTA operations expose the update target that created them in graphql ([#356](https://github.com/edgehog-device-manager/edgehog/issues/356). | |||
| - Azure support | |||
There was a problem hiding this comment.
Azure support for what?
Written like this it could mean anything: e.g. we added support for deploying Edgehog services on AKS clusters.
A reference to the relevant issue would be a bonus point.
It could be something like:
Support for using Azure Storage as the persistence layer for asset uploads ([#233](https://github.com/edgehog-device-manager/edgehog/issues/233)).add azure support by adding a waffle compatible storage module based on azurex. new environment variables were added for configuration: - STORAGE_TYPE, which can be either s3 or azure - AZURE_BLOB_ENDPOINT: equivalent to s3's asset_host. maps to azurex's api_url. - AZURE_REGION: the region for the blob storage. only used if AZURE_BLOB_ENDPOINT is unset. - AZURE_CONTAINER: equivalent to s3's bucket - AZURE_STORAGE_ACCOUNT_NAME: azure's AccountName - AZURE_STORAGE_ACCOUNT_KEY: azure's AccountKey - AZURE_CONNECTION_STRING: an azure connection string. maps to previous values. Signed-off-by: Francesco Noacco <[email protected]>
davidebriani
approved these changes
Dec 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add azure support by adding a waffle compatible storage module based on azurex.
the configuration mostly maps to existing s3 configuration, so for now I did not deem it necessary to separate the configuration. I am however open to implementing a separate configuration if this was preferred though.
Two new environment variables were added for configuration:
also add integration tests and allow runtime configuration of s3 storage
closes #233