contextual improvements #7410
pr.yml
on: pull_request
SwiftLint
34s
ShellCheck
5s
Unit Tests
6m 41s
Make Release Build
4m 45s
Annotations
1 error, 26 warnings, and 2 notices
SwiftLint:
DuckDuckGoTests/OnboardingSuggestedSitesProviderTests.swift#L98
Colons should be next to the identifier when specifying a type and next to the key in dictionary literals (colon)
|
ShellCheck
The following actions uses Node.js version which is deprecated and will be forced to run on node20: actions/checkout@v3. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
|
SwiftLint
The following actions uses Node.js version which is deprecated and will be forced to run on node20: actions/checkout@v3. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
|
Make Release Build
The following actions uses Node.js version which is deprecated and will be forced to run on node20: webfactory/[email protected], actions/checkout@v3, actions/cache@v3. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
|
Make Release Build:
DerivedData/Build/Products/Release-iphonesimulator/PackageFrameworks/GRDB.framework/PrivateHeaders/grdb_config.h#L14
ambiguous expansion of macro 'SQLITE_VERSION_NUMBER'
|
Make Release Build:
Core/LegacyBookmarksCoreDataStorage.swift#L268
initialization of immutable value 'pixelParam' was never used; consider replacing with assignment to '_' or removing it
|
Make Release Build:
DerivedData/Build/Products/Release-iphonesimulator/PackageFrameworks/GRDB.framework/PrivateHeaders/grdb_config.h#L14
ambiguous expansion of macro 'SQLITE_VERSION_NUMBER'
|
Make Release Build:
Core/LegacyBookmarksCoreDataStorage.swift#L268
initialization of immutable value 'pixelParam' was never used; consider replacing with assignment to '_' or removing it
|
Make Release Build
Accent color ‘AccentColor’ is not present in any asset catalogs.
|
Make Release Build:
DerivedData/Build/Intermediates.noindex/DuckDuckGo.build/Release-iphonesimulator/WidgetsExtension.build/DerivedSources/GeneratedAssetSymbols.swift#L379
The "CreditCard-32-Color" image asset name resolves to the symbol "creditCard32" which already exists. Try renaming the asset.
|
Make Release Build:
DerivedData/Build/Intermediates.noindex/DuckDuckGo.build/Release-iphonesimulator/WidgetsExtension.build/DerivedSources/GeneratedAssetSymbols.swift#L678
The "Identity-32-Color" image asset name resolves to the symbol "identity32" which already exists. Try renaming the asset.
|
Make Release Build:
DerivedData/Build/Intermediates.noindex/DuckDuckGo.build/Release-iphonesimulator/WidgetsExtension.build/DerivedSources/GeneratedAssetSymbols.swift#L815
The "Login-32-Color" image asset name resolves to the symbol "login32" which already exists. Try renaming the asset.
|
Make Release Build:
DerivedData/Build/Intermediates.noindex/DuckDuckGo.build/Release-iphonesimulator/WidgetsExtension.build/DerivedSources/GeneratedAssetSymbols.swift#L910
The "Note-32-Color" image asset name resolves to the symbol "note32" which already exists. Try renaming the asset.
|
Make Release Build:
DerivedData/Build/Intermediates.noindex/DuckDuckGo.build/Release-iphonesimulator/WidgetsExtension.build/DerivedSources/GeneratedAssetSymbols.swift#L379
The "CreditCard-32-Color" image asset name resolves to the symbol "creditCard32" which already exists. Try renaming the asset.
|
Make Release Build
xcbeautify 2.4.1 is already installed and up-to-date.
To reinstall 2.4.1, run:
brew reinstall xcbeautify
|
Unit Tests
The following actions uses Node.js version which is deprecated and will be forced to run on node20: actions/checkout@v3, actions/cache@v3, mikepenz/action-junit-report@v3. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
|
Unit Tests
xcbeautify 2.4.1 is already installed and up-to-date.
To reinstall 2.4.1, run:
brew reinstall xcbeautify
|
Unit Tests:
Core/LegacyBookmarksCoreDataStorage.swift#L268
initialization of immutable value 'pixelParam' was never used; consider replacing with assignment to '_' or removing it
|
Unit Tests
Accent color ‘AccentColor’ is not present in any asset catalogs.
|
Unit Tests:
DerivedData/Build/Intermediates.noindex/DuckDuckGo.build/Debug-iphonesimulator/WidgetsExtension.build/DerivedSources/GeneratedAssetSymbols.swift#L379
The "CreditCard-32-Color" image asset name resolves to the symbol "creditCard32" which already exists. Try renaming the asset.
|
Unit Tests:
DerivedData/Build/Intermediates.noindex/DuckDuckGo.build/Debug-iphonesimulator/WidgetsExtension.build/DerivedSources/GeneratedAssetSymbols.swift#L678
The "Identity-32-Color" image asset name resolves to the symbol "identity32" which already exists. Try renaming the asset.
|
Unit Tests:
DerivedData/Build/Intermediates.noindex/DuckDuckGo.build/Debug-iphonesimulator/WidgetsExtension.build/DerivedSources/GeneratedAssetSymbols.swift#L815
The "Login-32-Color" image asset name resolves to the symbol "login32" which already exists. Try renaming the asset.
|
Unit Tests:
DerivedData/Build/Intermediates.noindex/DuckDuckGo.build/Debug-iphonesimulator/WidgetsExtension.build/DerivedSources/GeneratedAssetSymbols.swift#L910
The "Note-32-Color" image asset name resolves to the symbol "note32" which already exists. Try renaming the asset.
|
Unit Tests:
DerivedData/Build/Intermediates.noindex/DuckDuckGo.build/Debug-iphonesimulator/WidgetsExtension.build/DerivedSources/GeneratedAssetSymbols.swift#L379
The "CreditCard-32-Color" image asset name resolves to the symbol "creditCard32" which already exists. Try renaming the asset.
|
Unit Tests:
DerivedData/Build/Intermediates.noindex/DuckDuckGo.build/Debug-iphonesimulator/WidgetsExtension.build/DerivedSources/GeneratedAssetSymbols.swift#L678
The "Identity-32-Color" image asset name resolves to the symbol "identity32" which already exists. Try renaming the asset.
|
Unit Tests:
DerivedData/Build/Intermediates.noindex/DuckDuckGo.build/Debug-iphonesimulator/WidgetsExtension.build/DerivedSources/GeneratedAssetSymbols.swift#L815
The "Login-32-Color" image asset name resolves to the symbol "login32" which already exists. Try renaming the asset.
|
Unit Tests:
DerivedData/Build/Intermediates.noindex/DuckDuckGo.build/Debug-iphonesimulator/WidgetsExtension.build/DerivedSources/GeneratedAssetSymbols.swift#L910
The "Note-32-Color" image asset name resolves to the symbol "note32" which already exists. Try renaming the asset.
|
Unit Tests
Skipped UnitTests.WebCacheManagerTests.testWhenClearedWithDataStoreContainerThenDDGCookiesAreRetained
|
Unit Tests
Tests Passed: 0 failed, 0 skipped, 30 total (13.538 seconds)
|