contextual improvements #3105
Merged
contextual improvements #3105
+75
−27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🚫 The Asana task linked in the PR description is not added to iOS App Board project.
|
github-actions
bot
added
the
bot: not in app board
SabrinaTardio
changed the title
SabrinaTardio
force-pushed
the
sabrina/contextual-improvements
branch
from
889d5b4 to
fa00ea0
Compare
alessandroboron
force-pushed
the
alessandro/contextual-experiment-factory
branch
from
e6e9b78 to
5afa6b9
Compare
Base automatically changed from
alessandro/contextual-experiment-factory
to
AleSab/implement-contextual-onboarding
July 18, 2024 22:51
alessandroboron
force-pushed
the
sabrina/contextual-improvements
branch
from
fa00ea0 to
6438ff6
Compare
|
|
||
| if !isNewOnboarding | ||
| && DaxDialogs.shared.shouldShowFireButtonPulse { | ||
| ViewHighlighter.hideAll() |
There was a problem hiding this comment.
did we add ViewHighlighter.hideAll() for old onboarding?
|
Just to double check, this is in the PR description |
alessandroboron
approved these changes
Jul 19, 2024
…ntextual-improvements
alessandroboron
approved these changes
Jul 22, 2024
alessandroboron
merged commit 211ee75
into
AleSab/implement-contextual-onboarding
11 of 13 checks passed
alessandroboron
added a commit
that referenced
this pull request
Jul 24, 2024
Co-authored-by: Alessandro Boron <[email protected]>
alessandroboron
added a commit
that referenced
this pull request
Jul 25, 2024
Co-authored-by: Alessandro Boron <[email protected]>
alessandroboron
added a commit
that referenced
this pull request
Jul 29, 2024
Co-authored-by: Alessandro Boron <[email protected]>
alessandroboron
added a commit
that referenced
this pull request
Aug 5, 2024
Co-authored-by: Alessandro Boron <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/1204186595873227/1207838822596053/f
Description: Shows the final contextual onboarding only if the fire dialog has been shown. Does not show the fire button overlay on tab switcher. Show fire dialog when trackers have been seen and fire dialog has not been seen.
Steps to test this PR:
1.
2.
Definition of Done (Internal Only):
Copy Testing:
’rather than'Orientation Testing:
Device Testing:
OS Testing:
Theme Testing:
Internal references:
Software Engineering Expectations
Technical Design Template