-
-
Notifications
You must be signed in to change notification settings - Fork 611
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GHA main: Add Alpine Linux job #20741
base: master
Are you sure you want to change the base?
Conversation
Thanks for your pull request and interest in making D better, @kinke! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please see CONTRIBUTING.md for more information. If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment. Bugzilla referencesYour PR doesn't reference any Bugzilla issue. If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog. Testing this PR locallyIf you don't have a local development environment setup, you can use Digger to test this PR: dub run digger -- build "master + dmd#20741" |
0560b3a
to
e6c031a
Compare
@JohanEngelen: Looks like there's no exception stack trace support for musl here upstream. I guess we'd need to upstream some druntime changes in ldc-developers/ldc#4639 and ldc-developers/ldc#4691? |
yes indeed! |
33c770e
to
ae8d4ce
Compare
@JohanEngelen: Okay, I've merged your two PRs to a single commit suitable for upstream here, as 2nd commit; the 3rd commit shows that it works, allowing to re-enable most hacked-out tests. Please extract it to its own PR and make sure it gets merged, as prerequisite of this PR. [It's your work after all, and you probably remember most details that could come up during a review.] |
No description provided.