Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GHA main: Add Alpine Linux job #20741

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from
Draft

GHA main: Add Alpine Linux job #20741

wants to merge 3 commits into from

Conversation

kinke
Copy link
Contributor

@kinke kinke commented Jan 20, 2025

No description provided.

@dlang-bot
Copy link
Contributor

Thanks for your pull request and interest in making D better, @kinke! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the coverage diff by visiting the details link of the codecov check)
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.


If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Your PR doesn't reference any Bugzilla issue.

If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog.

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub run digger -- build "master + dmd#20741"

@kinke kinke force-pushed the gha_alpine branch 10 times, most recently from 0560b3a to e6c031a Compare January 20, 2025 19:52
@kinke
Copy link
Contributor Author

kinke commented Jan 20, 2025

@JohanEngelen: Looks like there's no exception stack trace support for musl here upstream. I guess we'd need to upstream some druntime changes in ldc-developers/ldc#4639 and ldc-developers/ldc#4691?

@JohanEngelen
Copy link
Contributor

@JohanEngelen: Looks like there's no exception stack trace support for musl here upstream. I guess we'd need to upstream some druntime changes in ldc-developers/ldc#4639 and ldc-developers/ldc#4691?

yes indeed!

@kinke kinke force-pushed the gha_alpine branch 2 times, most recently from 33c770e to ae8d4ce Compare January 21, 2025 23:40
@kinke
Copy link
Contributor Author

kinke commented Jan 22, 2025

@JohanEngelen: Okay, I've merged your two PRs to a single commit suitable for upstream here, as 2nd commit; the 3rd commit shows that it works, allowing to re-enable most hacked-out tests. Please extract it to its own PR and make sure it gets merged, as prerequisite of this PR. [It's your work after all, and you probably remember most details that could come up during a review.]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants