Skip to content

Commit

Permalink
GHA main: Add Alpine Linux job
Browse files Browse the repository at this point in the history
  • Loading branch information
kinke committed Jan 20, 2025
1 parent ad947b5 commit 0560b3a
Show file tree
Hide file tree
Showing 8 changed files with 68 additions and 27 deletions.
18 changes: 14 additions & 4 deletions .github/workflows/main.yml
Original file line number Diff line number Diff line change
Expand Up @@ -49,6 +49,10 @@ jobs:
os: ubuntu-22.04
host_dmd: gdmd-9
disable_debug_for_dmd_unittests: true # no `-debug` - host frontend too old
- job_name: Alpine 3.21 x64, LDC
os: ubuntu-latest
container_image: alpine:3.21
host_dmd: ldmd2
# macOS
- job_name: macOS 13 x64, DMD (latest)
os: macos-13
Expand All @@ -74,6 +78,7 @@ jobs:
model: 32
name: ${{ matrix.job_name }}
runs-on: ${{ matrix.os }}
container: ${{ matrix.container_image }}
timeout-minutes: 40
env:
# for ci/run.sh:
Expand All @@ -90,6 +95,11 @@ jobs:
run:
shell: bash
steps:
- name: 'Alpine container: Pre-install bash, git and sudo'
if: startsWith(matrix.container_image, 'alpine')
shell: sh
run: apk add bash git sudo

- uses: actions/checkout@v4
with:
fetch-depth: 50
Expand Down Expand Up @@ -149,20 +159,20 @@ jobs:
- name: Test dmd
run: ci/run.sh test_dmd
- name: Test druntime
if: '!matrix.coverage'
if: '!matrix.coverage && (success() || failure())'
run: ci/run.sh test_druntime
- name: 'Windows x86: Add 32-bit libcurl.dll to PATH (required for Phobos unittests)'
if: runner.os == 'Windows' && env.MODEL == '32' && !matrix.coverage
if: runner.os == 'Windows' && env.MODEL == '32' && !matrix.coverage && (success() || failure())
run: |
# LDC
echo "$(dirname "$(which $DC)")/../lib32" >> $GITHUB_PATH
# DMD
echo "$(dirname "$(which $DC)")/../bin" >> $GITHUB_PATH
- name: Test phobos
if: '!matrix.coverage'
if: '!matrix.coverage && (success() || failure())'
run: ci/run.sh test_phobos
- name: Test self-compile
if: '!matrix.coverage' # already re-built with enabled coverage
if: '!matrix.coverage && (success() || failure())' # already re-built with enabled coverage
run: ENABLE_RELEASE=0 ci/run.sh rebuild
- name: Upload coverage report
if: matrix.coverage
Expand Down
28 changes: 17 additions & 11 deletions ci/cirrusci.sh
Original file line number Diff line number Diff line change
Expand Up @@ -15,18 +15,24 @@ if [ ! -z ${HOST_DC+x} ] ; then HOST_DMD=${HOST_DC}; fi
if [ -z ${HOST_DMD+x} ] ; then echo "Variable 'HOST_DMD' needs to be set."; exit 1; fi

if [ "$OS_NAME" == "linux" ]; then
export DEBIAN_FRONTEND=noninteractive
packages="git-core make g++ gdb gnupg curl libcurl4 tzdata zip unzip xz-utils llvm valgrind libc6-dbg"
if [ "$MODEL" == "32" ]; then
dpkg --add-architecture i386
packages="$packages g++-multilib libcurl4:i386 libc6-dbg:i386"
if type -P apk &>/dev/null; then
# Alpine
apk add git make g++ ldc \
bash grep coreutils diffutils curl gdb linux-headers dub
else
export DEBIAN_FRONTEND=noninteractive
packages="git-core make g++ gdb gnupg curl libcurl4 tzdata zip unzip xz-utils llvm valgrind libc6-dbg"
if [ "$MODEL" == "32" ]; then
dpkg --add-architecture i386
packages="$packages g++-multilib libcurl4:i386 libc6-dbg:i386"
fi
if [ "${HOST_DMD:0:4}" == "gdmd" ]; then
# ci/run.sh uses `sudo add-apt-repository ...` to add a PPA repo
packages="$packages sudo software-properties-common"
fi
apt-get -q update
apt-get install -yq $packages
fi
if [ "${HOST_DMD:0:4}" == "gdmd" ]; then
# ci/run.sh uses `sudo add-apt-repository ...` to add a PPA repo
packages="$packages sudo software-properties-common"
fi
apt-get -q update
apt-get install -yq $packages
elif [ "$OS_NAME" == "osx" ]; then
# upgrade GNU make
brew install make
Expand Down
13 changes: 13 additions & 0 deletions ci/run.sh
Original file line number Diff line number Diff line change
Expand Up @@ -123,6 +123,14 @@ test_dmd() {
local args=(ARGS="-O -inline -release")
fi

if type -P apk &>/dev/null; then
# FIXME: disable some failing tests on Alpine:
# * no TLS variables support with gdb: https://gitlab.alpinelinux.org/alpine/aports/-/issues/11154
rm compiler/test/runnable/gdb4181.d
# * some failure wrt. exception stack traces
rm compiler/test/runnable/{test19086.d,test17559.d}
fi

$build_path/dmd -g -i -Icompiler/test -release compiler/test/run.d -ofgenerated/run
generated/run -j$N --environment MODEL=$MODEL HOST_DMD=$build_path/dmd "${args[@]}"
}
Expand Down Expand Up @@ -262,6 +270,11 @@ install_host_compiler() {
echo "export DMD=gdmd-$gdc_version" > ~/dlang/gdc-$gdc_version/activate
echo "deactivate(){ echo;}" >> ~/dlang/gdc-$gdc_version/activate
fi
elif type -P apk &>/dev/null; then
# fake install script and create a fake 'activate' script
mkdir -p ~/dlang/$HOST_DMD
echo "export DMD=$HOST_DMD" > ~/dlang/$HOST_DMD/activate
echo "deactivate(){ echo;}" >> ~/dlang/$HOST_DMD/activate
else
local install_sh="install.sh"
download_install_sh "$install_sh"
Expand Down
2 changes: 1 addition & 1 deletion druntime/Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -427,7 +427,7 @@ HAS_ADDITIONAL_TESTS:=$(shell test -d test && echo 1)
ifeq ($(HAS_ADDITIONAL_TESTS),1)
ADDITIONAL_TESTS:=test/init_fini test/exceptions test/coverage test/profile test/cycles test/allocations test/typeinfo \
test/aa test/cpuid test/gc test/hash test/lifetime test/shared \
test/thread test/unittest test/imports test/betterc test/stdcpp test/config test/traits test/importc_compare
test/thread test/unittest test/imports test/betterc test/stdcpp test/config test/traits #test/importc_compare
ifeq (windows,$(OS))
ADDITIONAL_TESTS+=test/uuid
else
Expand Down
9 changes: 6 additions & 3 deletions druntime/test/exceptions/Makefile
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
TESTS=stderr_msg unittest_assert invalid_memory_operation unknown_gc static_dtor \
TESTS=stderr_msg unittest_assert invalid_memory_operation static_dtor \
future_message refcounted rt_trap_exceptions_drt catch_in_finally \
message_with_null

Expand All @@ -12,8 +12,11 @@ SED:=sed
GDB:=gdb

ifeq ($(OS),linux)
TESTS+=line_trace line_trace_21656 long_backtrace_trunc rt_trap_exceptions cpp_demangle \
memoryerror_null_read memoryerror_null_write memoryerror_null_call memoryerror_stackoverflow
TESTS+=line_trace line_trace_21656 long_backtrace_trunc rt_trap_exceptions cpp_demangle
# registerMemoryAssertHandler requires glibc; disable the tests on Alpine (apk tool available)
ifneq (1,$(shell which apk > /dev/null 2>&1 && echo 1))
TESTS+=memoryerror_null_read memoryerror_null_write memoryerror_null_call memoryerror_stackoverflow
endif
line_trace_dflags:=-L--export-dynamic
endif

Expand Down
13 changes: 10 additions & 3 deletions druntime/test/shared/src/finalize.d
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ void main(string[] args)
auto nf1 = new NoFinalize;
auto nf2 = new NoFinalizeBig;

shared size_t finalizeCounter;
static shared size_t finalizeCounter;
SetFinalizeCounter setFinalizeCounter;
loadSym(h, setFinalizeCounter, "setFinalizeCounter");
setFinalizeCounter(&finalizeCounter);
Expand All @@ -58,8 +58,15 @@ void main(string[] args)
auto r = Runtime.unloadLibrary(h);
if (!r)
assert(0);
if (finalizeCounter != 4)
assert(0);
version (CRuntime_Musl)
{
// On Musl, dlclose is a no-op
}
else
{
if (finalizeCounter != 4)
assert(0);
}
if (nf1._finalizeCounter)
assert(0);
if (nf2._finalizeCounter)
Expand Down
4 changes: 4 additions & 0 deletions druntime/test/shared/src/load.d
Original file line number Diff line number Diff line change
Expand Up @@ -143,6 +143,10 @@ void main(string[] args)
import core.sys.windows.winbase;
assert(!GetModuleHandleA(name.ptr));
}
else version (CRuntime_Musl)
{
// On Musl, dlclose is a no-op
}
else
{
import core.sys.posix.dlfcn : dlopen, RTLD_LAZY;
Expand Down
8 changes: 3 additions & 5 deletions druntime/test/shared/src/load_13414.d
Original file line number Diff line number Diff line change
Expand Up @@ -20,17 +20,15 @@ void runTest(string name)
*pLibSharedStaticDtorHook = &sharedStaticDtorHook;

const unloaded = Runtime.unloadLibrary(h);
assert(unloaded);
assert(tlsDtor == 1);
version (CRuntime_Musl)
{
// On Musl, unloadLibrary is a no-op because dlclose is a no-op
assert(!unloaded);
assert(tlsDtor == 0);
// On Musl, dlclose is a no-op
assert(dtor == 0);
}
else
{
assert(unloaded);
assert(tlsDtor == 1);
assert(dtor == 1);
}
}
Expand Down

0 comments on commit 0560b3a

Please sign in to comment.