Lazily fetch django user only on first load #33821
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Product Description
This is a performance improvement
Technical Summary
That call to
user.get_django_user()
takes something like 2.5 seconds on prod, since it does an inexact match:@gherceg is investigating whether it would be possible to switch to an exact match, which is much much faster. Meanwhile, it'd be better to skip the lookup regardless, and it turns out that's easy to do. From the docs:
Feature Flag
Safety Assurance
Safety story
This is a trivially simple change, and I believe test coverage is sufficient (though I'm verifying the performance improvement on staging)
Automated test coverage
QA Plan
Rollback instructions
Labels & Review