Performance improvements for selecting django user #33825
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jingcheng16
approved these changes
Dec 1, 2023
millerdev
reviewed
Dec 4, 2023
| @@ -1170,7 +1170,7 @@ def get_django_user(self, use_primary_db=False): | |||
| queryset = User.objects | |||
| if use_primary_db: | |||
| queryset = queryset.using(router.db_for_write(User)) | |||
| return queryset.get(username__iexact=self.username) | |||
| return queryset.get(username=self.username) | |||
There was a problem hiding this comment.
Can you say a bit about how you determined that this change was safe?
There was a problem hiding this comment.
Take a look at #33824 and feel free to ask any questions there.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Product Description
Technical Summary
Includes commits from the following PRs:
Feature Flag
Safety Assurance
Safety story
Automated test coverage
QA Plan
Rollback instructions
Labels & Review