Skip to content

Commit

Permalink
ADD: catch if there is a hole, it stops
Browse files Browse the repository at this point in the history
  • Loading branch information
9and3 committed Apr 17, 2024
1 parent a928f89 commit c4a4a3f
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 1 deletion.
2 changes: 2 additions & 0 deletions src/gh/diffCheck/diffCheck/df_joint_detector.py
Original file line number Diff line number Diff line change
Expand Up @@ -101,6 +101,8 @@ def run(self) :
break

if is_hole:
# TODO: for future development get rid of error
raise NotImplementedError("Hole detected, not implemented yet.")
self._holes.append(b)
elif is_cut:
self._cuts.append(b)
Expand Down
2 changes: 1 addition & 1 deletion src/gh/diffCheck/diffCheck_app.py
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@
:param i_export_dir: directory to export the xml
:param i_dump: whether to dump the xml
"""
# data_faces = diffCheck.df_joint_detector.JointDetector(i_breps[0]).run()
# o_joints = diffCheck.df_joint_detector.JointDetector(i_breps[0]).run()
# beams
beams = []
for brep in i_breps:
Expand Down

0 comments on commit c4a4a3f

Please sign in to comment.