FIX: catching non-planar faces

diffCheckOrg · Apr 17, 2024 · a928f89 · a928f89
1 parent f32b840
commit a928f89
Show file tree

Hide file tree

Showing 4 changed files with 997 additions and 257 deletions.
diff --git a/deps/eigen b/deps/eigen
diff --git a/src/gh/diffCheck/diffCheck/df_joint_detector.py b/src/gh/diffCheck/diffCheck/df_joint_detector.py
@@ -8,6 +8,8 @@
 import diffCheck.df_util
 import diffCheck.df_transformations
 
+from Grasshopper.Kernel import GH_RuntimeMessageLevel as RML
+
 
 @dataclass
 class JointDetector:
@@ -153,10 +155,11 @@ def run(self) :
                 if f_b is not None:
                     if f_b.IsSolid:
                         self._cuts.append(f_b)
-            for f_b in non_flat_faces_b:
-                if f_b is not None:
-                    if f_b.IsSolid:
-                        self._holes.append(f_b)
+            if non_flat_faces_b is not None and len(non_flat_faces_b) > 0:
+                for f_b in non_flat_faces_b:
+                    if f_b is not None:
+                        if f_b.IsSolid:
+                            self._holes.append(f_b)
 
         ############################################################################
         # 3. Sort faces from joints and faces from sides
@@ -195,4 +198,7 @@ def run(self) :
             if not is_joint:
                 self._faces.append([f, None])
 
+        if self._faces is None or len(self._faces) == 0:
+            ghenv.Component.AddRuntimeMessage(RML.Error, "No faces found after joint detection.")
+
         return self._faces
diff --git a/src/gh/diffCheck/diffCheck/diffCheck_app.py → src/gh/diffCheck/diffCheck_app.py b/src/gh/diffCheck/diffCheck/diffCheck_app.py → src/gh/diffCheck/diffCheck_app.py
@@ -9,11 +9,8 @@
 import diffCheck
 import diffCheck.df_geometries
 
-import sys
-import importlib
-for key in list(sys.modules.keys()):
-    if "diffCheck" in key:
-        importlib.reload(sys.modules[key])
+print(diffCheck.__version__)
+
 
 if __name__ == "__main__":
     """
@@ -22,6 +19,7 @@
         :param i_export_dir: directory to export the xml
         :param i_dump: whether to dump the xml
     """
+    # data_faces = diffCheck.df_joint_detector.JointDetector(i_breps[0]).run()
     # beams
     beams = []
     for brep in i_breps: