Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(portfolio): simplify getTopTokens and improve naming consistency #6167

Merged
merged 12 commits into from
Jan 16, 2025
Merged

refactor(portfolio): simplify getTopTokens and improve naming consistency #6167

merged 12 commits into from
Jan 16, 2025

Conversation

yhabib
Copy link
Contributor

@yhabib yhabib commented Jan 15, 2025 •
edited
Loading

Motivation

Simplifies code and maintains consistent naming conventions.

Changes

  • Removed an unnecessary parameter in getTopTokens.
  • Renamed userTokensData to userTokens for accuracy, as the type is UserToken.
  • Renamed topTokens to topHeldTokens to maintain consistency with topStakedTokens.
  • Renamed TokensCard and NoTokensCard to HeldTokensCard and NoHeldTokensCard

Tests

  • The tests should pass as it did before.

Todos

  • Add entry to changelog (if necessary).
    Not necessary

@yhabib yhabib marked this pull request as ready for review January 16, 2025 07:54
@yhabib yhabib requested a review from a team as a code owner January 16, 2025 07:54
mstrasinskis
mstrasinskis reviewed Jan 16, 2025
View reviewed changes
Copy link
Contributor

@mstrasinskis mstrasinskis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What do you think about a more significant renaming, as mentioned here?

@yhabib yhabib mentioned this pull request Jan 16, 2025
Merged
1 task
@yhabib yhabib force-pushed the nns1-2521/clean-up branch from 5972af7 to ef508ed Compare January 16, 2025 13:31
mstrasinskis
mstrasinskis approved these changes Jan 16, 2025
View reviewed changes
Copy link
Contributor

@mstrasinskis mstrasinskis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

frontend/src/lib/components/portfolio/TokensCard.svelte Show resolved Hide resolved
@yhabib yhabib force-pushed the nns1-2521/clean-up branch from ef508ed to 26975e4 Compare January 16, 2025 15:21
@yhabib yhabib added this pull request to the merge queue Jan 16, 2025
Merged via the queue into main with commit e8f6469 Jan 16, 2025
32 checks passed
@yhabib yhabib deleted the nns1-2521/clean-up branch January 16, 2025 19:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mstrasinskis mstrasinskis mstrasinskis approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yhabib @mstrasinskis