Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(portfolio): implement ProjectsCard component #6166

Merged
merged 6 commits into from
Jan 16, 2025
Merged

feat(portfolio): implement ProjectsCard component #6166

merged 6 commits into from
Jan 16, 2025

Conversation

yhabib
Copy link
Contributor

@yhabib yhabib commented Jan 15, 2025

Motivation

The ProjectsCard component on the Portfolio page displays the total USD amount of staked in projects and a list of up to four projects. If there is a difference of 1 or more with the number of top Tokens it shows a information message.

Related PRs:

Changes

  • Adds the ProjectsCard component.

Tests

  • Unit tests for the component
  • New page object for the component
  • Manually tested in E2E environment

Todos

  • Add entry to changelog (if necessary).
    Not necessary

@yhabib yhabib marked this pull request as ready for review January 15, 2025 16:30
@yhabib yhabib requested a review from a team as a code owner January 15, 2025 16:30
Copy link
Contributor

@mstrasinskis mstrasinskis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! There are a bunch of not critical suggestions.

@yhabib yhabib added this pull request to the merge queue Jan 16, 2025
Merged via the queue into main with commit 518778c Jan 16, 2025
32 checks passed
@yhabib yhabib deleted the nns1-3522 branch January 16, 2025 12:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants