feature: add feature flag guard for new account select component #268
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Sep 20, 2023
|
Current dependencies on/for this PR:
This comment was auto-generated by Graphite. |
This was referenced Sep 20, 2023
jackson-dean
force-pushed
the
09-20-chore_update_copy_per_Ed_s_request
branch
from
d69d940
to
2274015
Compare
jackson-dean
force-pushed
the
09-20-feature_add_feature_flag_guard_for_new_account_select_component
branch
from
3bcfc06
to
2dd6da4
Compare
jackson-dean
force-pushed
the
09-20-chore_update_copy_per_Ed_s_request
branch
from
2274015
to
07f9ab4
Compare
jackson-dean
force-pushed
the
09-20-feature_add_feature_flag_guard_for_new_account_select_component
branch
from
2dd6da4
to
ef3f623
Compare
jackson-dean
force-pushed
the
09-20-chore_update_copy_per_Ed_s_request
branch
from
07f9ab4
to
535e4b7
Compare
jackson-dean
force-pushed
the
09-20-feature_add_feature_flag_guard_for_new_account_select_component
branch
from
ef3f623
to
3fb5d28
Compare
lazynina
approved these changes
Sep 20, 2023
jackson-dean
force-pushed
the
09-20-chore_update_copy_per_Ed_s_request
branch
from
535e4b7
to
4e78cc4
Compare
jackson-dean
force-pushed
the
09-20-feature_add_feature_flag_guard_for_new_account_select_component
branch
from
3fb5d28
to
9348f4a
Compare
jackson-dean
force-pushed
the
09-20-chore_update_copy_per_Ed_s_request
branch
from
4e78cc4
to
7f99816
Compare
jackson-dean
force-pushed
the
09-20-feature_add_feature_flag_guard_for_new_account_select_component
branch
from
9348f4a
to
f7b8093
Compare
jackson-dean
force-pushed
the
09-20-chore_update_copy_per_Ed_s_request
branch
from
7f99816
to
2196170
Compare
jackson-dean
force-pushed
the
09-20-feature_add_feature_flag_guard_for_new_account_select_component
branch
from
f7b8093
to
4258114
Compare
jackson-dean
force-pushed
the
09-20-chore_update_copy_per_Ed_s_request
branch
from
2196170
to
90286f5
Compare
Base automatically changed from
09-20-chore_update_copy_per_Ed_s_request
to
09-20-feature_new_component_for_sub_account_UI
September 21, 2023 18:58
jackson-dean
force-pushed
the
09-20-feature_add_feature_flag_guard_for_new_account_select_component
branch
from
4258114
to
604cdc3
Compare
jackson-dean
force-pushed
the
09-20-feature_new_component_for_sub_account_UI
branch
from
90286f5
to
b9294b4
Compare
jackson-dean
changed the base branch from
09-20-feature_new_component_for_sub_account_UI
to
09-20-chore_update_copy_per_Ed_s_request
jackson-dean
force-pushed
the
09-20-feature_add_feature_flag_guard_for_new_account_select_component
branch
from
604cdc3
to
052cf58
Compare
jackson-dean
force-pushed
the
09-20-chore_update_copy_per_Ed_s_request
branch
from
0367955
to
7038dbc
Compare
jackson-dean
force-pushed
the
09-20-feature_add_feature_flag_guard_for_new_account_select_component
branch
from
052cf58
to
c72c600
Compare
Base automatically changed from
09-20-chore_update_copy_per_Ed_s_request
to
09-20-feature_new_component_for_sub_account_UI
September 22, 2023 04:40
jackson-dean
force-pushed
the
09-20-feature_new_component_for_sub_account_UI
branch
2 times, most recently
from
ca676f9
to
ba80637
Compare
jackson-dean
force-pushed
the
09-20-feature_add_feature_flag_guard_for_new_account_select_component
branch
from
c72c600
to
30de30f
Compare
This was referenced Sep 22, 2023
Merged
jackson-dean
merged commit b51b772
into
09-20-feature_new_component_for_sub_account_UI
1 check passed
jackson-dean
deleted the
09-20-feature_add_feature_flag_guard_for_new_account_select_component
branch
jackson-dean
added a commit
that referenced
this pull request
Sep 25, 2023
* feature: new component for sub account UI * feature: add feature flag guard for new account select component (#268) * feature: add feature flag guard for new account select component * feature: backup seed component (#269) * feature: backup seed component * feature: add balance to account selector UI (#270) * feature: add balance to account selector UI * migrate swal to mat dialog (#273) * migrate swal to mat dialog * update button styles (#277) * update button styles * review feedback and bug fixes (#279)
jackson-dean
added a commit
that referenced
this pull request
Sep 25, 2023
* feature: new component for sub account UI * feature: add feature flag guard for new account select component (#268) * feature: add feature flag guard for new account select component * feature: backup seed component (#269) * feature: backup seed component * feature: add balance to account selector UI (#270) * feature: add balance to account selector UI * migrate swal to mat dialog (#273) * migrate swal to mat dialog * update button styles (#277) * update button styles * review feedback and bug fixes (#279)
jackson-dean
added a commit
that referenced
this pull request
Sep 25, 2023
* feature: new component for sub account UI * feature: add feature flag guard for new account select component (#268) * feature: add feature flag guard for new account select component * feature: backup seed component (#269) * feature: backup seed component * feature: add balance to account selector UI (#270) * feature: add balance to account selector UI * migrate swal to mat dialog (#273) * migrate swal to mat dialog * update button styles (#277) * update button styles * review feedback and bug fixes (#279)
lazynina
added a commit
that referenced
this pull request
Nov 26, 2023
* refactor: update account service to support sub accounts * feature: new component for sub account UI (#266) * feature: new component for sub account UI * feature: add feature flag guard for new account select component (#268) * feature: add feature flag guard for new account select component * feature: backup seed component (#269) * feature: backup seed component * feature: add balance to account selector UI (#270) * feature: add balance to account selector UI * migrate swal to mat dialog (#273) * migrate swal to mat dialog * update button styles (#277) * update button styles * review feedback and bug fixes (#279) * Cleanup UI for multiple account mgmt (#280) * cleanup UI for multiple accout mgmt * run prettier * fix margin on metamask account * formatting * fix mobile * fix scrolling on overlay --------- Co-authored-by: Lazy Nina <> * auto, not scroll for overflow-y on overlay * fix sub account key generation (#281) * update cookie options in put and update logic for mustUseStorageAccess (#286) * update cookie options in put and update logic for mustUseStorageAccess * format * fix sameSite none * run format * add testnet verify-captcha to caddyfile * fix affiliateAddress for heroswap iframe in identity (#287) Co-authored-by: Lazy Nina <> --------- Co-authored-by: Lazy Nina <> --------- Co-authored-by: Ed Moss <[email protected]> Co-authored-by: Lazy Nina <> Co-authored-by: Lazy Nina <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a guard for the new sub account features that makes it "opt in."
The reason we do this is because there are breaking changes that
external developers will need to do some migration work in order to
use it.
We will have a follow up PR in the default frontend (https://node.deso.org),
that gives a clear example of how to change the code in order to use
the new sub account features. Note that this is only applicable for apps
using the legacy iframe API. Anyone using the new desojs lib will simply
pick up the new features automatically.