-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: update account service to support sub accounts #264
Merged
lazynina
merged 7 commits into
main
from
09-20-refactor_update_account_service_to_support_sub_accounts
Nov 26, 2023
Merged
refactor: update account service to support sub accounts #264
lazynina
merged 7 commits into
main
from
09-20-refactor_update_account_service_to_support_sub_accounts
Nov 26, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current dependencies on/for this PR:
This comment was auto-generated by Graphite. |
This was referenced Sep 20, 2023
jackson-dean
force-pushed
the
09-20-chore_update_configs_only
branch
from
September 20, 2023 20:09
c4b62dd
to
5fd8601
Compare
jackson-dean
force-pushed
the
09-20-refactor_update_account_service_to_support_sub_accounts
branch
from
September 20, 2023 20:09
2598365
to
f094d79
Compare
jackson-dean
force-pushed
the
09-20-chore_update_configs_only
branch
from
September 20, 2023 20:11
5fd8601
to
d78182a
Compare
jackson-dean
force-pushed
the
09-20-refactor_update_account_service_to_support_sub_accounts
branch
from
September 20, 2023 20:11
f094d79
to
fa3fc25
Compare
lazynina
approved these changes
Sep 20, 2023
jackson-dean
force-pushed
the
09-20-refactor_update_account_service_to_support_sub_accounts
branch
3 times, most recently
from
September 21, 2023 05:10
d837316
to
ee083ff
Compare
jackson-dean
force-pushed
the
09-20-chore_update_configs_only
branch
from
September 21, 2023 18:58
d78182a
to
75d9df5
Compare
jackson-dean
force-pushed
the
09-20-refactor_update_account_service_to_support_sub_accounts
branch
2 times, most recently
from
September 21, 2023 19:15
8d0c9d4
to
5e487db
Compare
jackson-dean
force-pushed
the
09-20-chore_update_configs_only
branch
from
September 21, 2023 19:16
75d9df5
to
7e6b59d
Compare
jackson-dean
force-pushed
the
09-20-refactor_update_account_service_to_support_sub_accounts
branch
from
September 21, 2023 19:18
5e487db
to
f334f81
Compare
jackson-dean
force-pushed
the
09-20-refactor_update_account_service_to_support_sub_accounts
branch
from
September 21, 2023 23:34
f334f81
to
14e26d9
Compare
jackson-dean
force-pushed
the
09-20-refactor_update_account_service_to_support_sub_accounts
branch
from
September 22, 2023 04:51
d30fa1c
to
14e26d9
Compare
jackson-dean
force-pushed
the
09-20-refactor_update_account_service_to_support_sub_accounts
branch
from
September 22, 2023 05:40
14e26d9
to
656702e
Compare
jackson-dean
force-pushed
the
09-20-refactor_update_account_service_to_support_sub_accounts
branch
from
September 22, 2023 05:44
656702e
to
5ea24e3
Compare
This was referenced Sep 22, 2023
Merged
jackson-dean
force-pushed
the
09-20-refactor_update_account_service_to_support_sub_accounts
branch
from
September 25, 2023 18:42
25b37ce
to
668ba78
Compare
* feature: new component for sub account UI * feature: add feature flag guard for new account select component (#268) * feature: add feature flag guard for new account select component * feature: backup seed component (#269) * feature: backup seed component * feature: add balance to account selector UI (#270) * feature: add balance to account selector UI * migrate swal to mat dialog (#273) * migrate swal to mat dialog * update button styles (#277) * update button styles * review feedback and bug fixes (#279)
jackson-dean
force-pushed
the
09-20-refactor_update_account_service_to_support_sub_accounts
branch
from
September 25, 2023 18:49
668ba78
to
7027d24
Compare
* cleanup UI for multiple accout mgmt * run prettier * fix margin on metamask account * formatting * fix mobile * fix scrolling on overlay --------- Co-authored-by: Lazy Nina <>
…port_sub_accounts
lazynina
deleted the
09-20-refactor_update_account_service_to_support_sub_accounts
branch
November 26, 2023 15:59
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes the way accounts are stored to support sub accounts.
An overview of the storage strategy:
in a
users
key in local storage that is keyed on the public key of the root account.subAccounts
property on the root account. These subaccountsconsist of the following props:
{ accountNumber, lastLoginTimestamp, isHidden }
. The public keycan be derived from this information combined with the seed stored on the root user.
We need this to support look up by public key when a consuming application passes us a public key for
the logged in user.
NOTE: There is nothing special about the root account. It is only for historical reasons that we key
the common data (seed, mnemonic, etc) under this account's public key. In practice, all accounts are
derived the same and all sub accounts are fully fledged and unique "owner" accounts that can be
issued their own derived keys and can sign with their own public/private keys.