Update Fee Estimation minFeeRateNanosPerKB to overrideFeeRateNanosPerKB #1255
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Apr 22, 2024
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @tholonious and the rest of your teammates on |
Base automatically changed from
diamondhands/KILL-LAST-MEMPOOL-FEE-ESTIMATION-BUGS
to
feature/proof-of-stake
April 22, 2024 18:41
This was referenced Apr 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Followup PR from #1252
minFeeRateNanosPerKB, but we were ignoring it if the fee estimators returned a higher fee. This was much less useful than using the minFeeRateNanosPerKB as a straight-up override so I changed the behavior there. Doing this made it so that my script was able to blast the mempool with txns, with a custom fee rate, without any reordering issues (because all the txns were being put in the same fee bucket). Eventually, we should probably change the name of this field to something likeoverrideFeeRateNanosPerKBbut I think it's fine for now.