-
Notifications
You must be signed in to change notification settings - Fork 108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create Global Params For Fee Estimator Congestion and Priority Params #1258
Create Global Params For Fee Estimator Congestion and Priority Params #1258
Conversation
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @tholonious and the rest of your teammates on Graphite |
b570586
to
3f2401d
Compare
c61096e
to
6bd1a19
Compare
"_connectUpdateGlobalParams: unable to decode MempoolPastBlocksPriorityPercentileBasisPoints as uint64", | ||
) | ||
} | ||
newGlobalParamsEntry.MempoolPastBlocksPriorityPercentileBasisPoints = val |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I probably would have named this PastBlocksPriorityPercentileBasisPoints
instead of MempoolPastBlocksPriorityPercentileBasisPoints
or would have used a prefix like FeeEstimator
for these so we would have FeeEstimatorPastBlocksPriorityPercentileBasisPoints
. That feels a bit wordy tho. I just think using Mempool
as a prefix is a bit confusing, but these were the names DH was using so if that's what he wants, it's fine by me.
Merge activity
|
6bd1a19
to
03f90a4
Compare
Create Global Params For Fee Estimator Congestion and Priority Params
Implement encode and decode
Rename