Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create Global Params For Fee Estimator Congestion and Priority Params #1258

Conversation

tholonious
Copy link
Contributor

Create Global Params For Fee Estimator Congestion and Priority Params

Implement encode and decode

Rename

@tholonious tholonious marked this pull request as ready for review April 22, 2024 20:44
@tholonious tholonious requested a review from a team as a code owner April 22, 2024 20:44
@tholonious tholonious force-pushed the Add_Default_Prefix_to_New_Fee_Estimation_Constant_Names branch from b570586 to 3f2401d Compare April 22, 2024 21:02
@tholonious tholonious force-pushed the Create_Global_Params_For_Fee_Estimator_Congestion_and_Priority_Params branch from c61096e to 6bd1a19 Compare April 22, 2024 21:02
"_connectUpdateGlobalParams: unable to decode MempoolPastBlocksPriorityPercentileBasisPoints as uint64",
)
}
newGlobalParamsEntry.MempoolPastBlocksPriorityPercentileBasisPoints = val
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I probably would have named this PastBlocksPriorityPercentileBasisPoints instead of MempoolPastBlocksPriorityPercentileBasisPoints or would have used a prefix like FeeEstimator for these so we would have FeeEstimatorPastBlocksPriorityPercentileBasisPoints. That feels a bit wordy tho. I just think using Mempool as a prefix is a bit confusing, but these were the names DH was using so if that's what he wants, it's fine by me.

Copy link
Contributor Author

tholonious commented Apr 23, 2024

Merge activity

  • Apr 22, 10:39 PM EDT: @tholonious started a stack merge that includes this pull request via Graphite.
  • Apr 22, 10:40 PM EDT: Graphite rebased this pull request as part of a merge.
  • Apr 22, 10:41 PM EDT: @tholonious merged this pull request with Graphite.

Base automatically changed from Add_Default_Prefix_to_New_Fee_Estimation_Constant_Names to feature/proof-of-stake April 23, 2024 02:40
@tholonious tholonious force-pushed the Create_Global_Params_For_Fee_Estimator_Congestion_and_Priority_Params branch from 6bd1a19 to 03f90a4 Compare April 23, 2024 02:40
@tholonious tholonious merged commit 617825f into feature/proof-of-stake Apr 23, 2024
3 of 4 checks passed
@tholonious tholonious deleted the Create_Global_Params_For_Fee_Estimator_Congestion_and_Priority_Params branch April 23, 2024 02:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants