build: fix private/protected naming convention & improve boolean one

[davidlj95]

Private and protected naming convention wasn't enforced. Turns out it was because modifiers works by combining them in and and/&& fashion. So only private & protected (not possible) code was enforced. Instead, we want both protected and private code to have same rules. Uses a map to avoid repeating the same rules twice. Nothing is added for #private, the hashtag is enough.

Then, enforces a bit more the boolean naming convention. By specifying all available selectors that aren't too greedy (i.e.: object literal expressions are a bit too much, can't control some of them as they're external)

Finally, types ElementRef elements around / doesn't store those in class if possible

[davidlj95]

• build: fix private/protected naming convention & improve boolean one #891 👈 (View in Graphite)
• main

This stack of pull requests is managed by Graphite. Learn more about stacking.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.31%. Comparing base (4829a32) to head (b21450c).
Report is 1 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #891      +/-   ##
==========================================
- Coverage   98.32%   98.31%   -0.01%     
==========================================
  Files         122      122              
  Lines         597      595       -2     
  Branches       62       62              
==========================================
- Hits          587      585       -2     
  Misses          6        6              
  Partials        4        4              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.