Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: improve coverage on collapsible tree node sibling test #893

Conversation

davidlj95
Copy link
Owner

#891 failed due to low patch coverage. However the issue is actually that CollapsibleTreeNode.collapseAllChildren isn't covered. There's a test about it, but doesn't use the actual implementation due to the use of a spy.

To actually test the method works as expected, refactoring the test so that method implementation isn't spied. Moves the test apart as it requires a bit of special setup.

Copy link
Owner Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

Copy link

codecov bot commented Nov 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.72%. Comparing base (1389835) to head (7b948b0).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #893      +/-   ##
==========================================
+ Coverage   96.23%   96.72%   +0.49%     
==========================================
  Files         124      124              
  Lines         611      611              
  Branches       68       68              
==========================================
+ Hits          588      591       +3     
+ Misses         19       16       -3     
  Partials        4        4              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@davidlj95 davidlj95 merged commit a310174 into main Nov 29, 2024
15 checks passed
@davidlj95 davidlj95 deleted the stacked/test-improve-coverage-on-collapsible-tree-node-sibling-test branch November 29, 2024 10:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant