[PECO-1125]Add staging ingestion tests to PySql (Cloned from PECO-840) #234
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prior to this change, the test would pass for _any_ failure. This was an oversight when writing the tests originally. Signed-off-by: Jesse Whitehouse <[email protected]> (2/8) Copy staging_ingestion_tests.py as a base for uc volume tests Signed-off-by: Jesse Whitehouse <[email protected]> (3/8) Rename mixin and wire in new tests to be discovered by pytest Signed-off-by: Jesse Whitehouse <[email protected]> (4/8) Remove staging_ingestion_user env var check Signed-off-by: Jesse Whitehouse <[email protected]> (5/8) Check for catalog and schema env vars Signed-off-by: Jesse Whitehouse <[email protected]> (6/8) I ran a CREATE VOLUME statement which succeeded on our test infra Signed-off-by: Jesse Whitehouse <[email protected]> (7/8) Rename all test methods Signed-off-by: Jesse Whitehouse <[email protected]> (8/8) Replace all staging paths with Volumes paths Signed-off-by: Jesse Whitehouse <[email protected]>
nithinkdb
requested review from
susodapop,
arikfr,
yunbodeng-db and
andrefurlan-db
as code owners
nithinkdb
changed the title
|
Tests are already written for this. Closing and will reopen with the latest changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We need to add a suite of e2e tests for UC Volume ingestion.