[PECO-840] Port staging ingestion behaviour to new UC Volumes #235
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 11 commits
July 1, 2023 12:14
Prior to this change, the test would pass for _any_ failure. This was an oversight when writing the tests originally. Signed-off-by: Jesse Whitehouse <[email protected]>
Signed-off-by: Jesse Whitehouse <[email protected]>
Signed-off-by: Jesse Whitehouse <[email protected]>
Signed-off-by: Jesse Whitehouse <[email protected]>
Signed-off-by: Jesse Whitehouse <[email protected]>
Signed-off-by: Jesse Whitehouse <[email protected]>
Signed-off-by: Jesse Whitehouse <[email protected]>
Signed-off-by: Jesse Whitehouse <[email protected]> Fix broken test: we need to place files into the e2etests subdirectory Signed-off-by: Jesse Whitehouse <[email protected]>
staging locations but UC volumes dooes not have personal staging locations. Signed-off-by: Jesse Whitehouse <[email protected]>
is different than was PSL Signed-off-by: Jesse Whitehouse <[email protected]>
Signed-off-by: Jesse Whitehouse <[email protected]>
susodapop
requested review from
arikfr,
yunbodeng-db and
andrefurlan-db
as code owners
|
I synced with |
benc-db
approved these changes
Sep 29, 2023
Signed-off-by: Jesse Whitehouse <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Last year we introduced staging locations, a feature which is being phased out with UC volumes instead. No change is needed to the connector except to update our e2e tests to use the new UC volumes syntax. Which is what this pull request implements. I originally wrote this change in July 2023, as the feature was first rolling out and we didn't have a server to test against. We now have that server and I have verified that all our tests pass.
Related Tickets & Documents
This is a reopen of #234 and #167