Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[PECO-840] WIP #167

Closed
wants to merge 10 commits into from
Closed

[PECO-840] WIP #167

wants to merge 10 commits into from

Conversation

susodapop
Copy link
Contributor

No description provided.

Jesse Whitehouse added 10 commits July 1, 2023 12:14
(1/8) Make staging ingestion e2e fail conditions more specific
74b286a 
Prior to this change, the test would pass for _any_ failure. This was
an oversight when writing the tests originally.

Signed-off-by: Jesse Whitehouse <[email protected]>
(2/8) Copy staging_ingestion_tests.py as a base for uc volume tests
f7c505f 
Signed-off-by: Jesse Whitehouse <[email protected]>
(3/8) Rename mixin and wire in new tests to be discovered by pytest
1f391c2 
Signed-off-by: Jesse Whitehouse <[email protected]>
(4/8) Remove staging_ingestion_user env var check
846a503 
Signed-off-by: Jesse Whitehouse <[email protected]>
(5/8) Check for catalog and schema env vars
051b3eb 
Signed-off-by: Jesse Whitehouse <[email protected]>
(6/8) I ran a CREATE VOLUME statement which succeeded on our test infra
ecdeba1 
Signed-off-by: Jesse Whitehouse <[email protected]>
(7/8) Rename all test methods
2104cc7 
Signed-off-by: Jesse Whitehouse <[email protected]>
(8/8) Replace all staging paths with Volumes paths
a75878d 
Signed-off-by: Jesse Whitehouse <[email protected]>

Fix broken test: we need to place files into the e2etests subdirectory

Signed-off-by: Jesse Whitehouse <[email protected]>
Remove this test from uc volume tests. It was originally copied from
d3a41a8 
staging locations but UC volumes dooes not have personal staging locations.

Signed-off-by: Jesse Whitehouse <[email protected]>
UC Volumes uses different warning text, so the text of the exception
11c2499 
is different than was PSL

Signed-off-by: Jesse Whitehouse <[email protected]>
@susodapop
Copy link
Contributor Author

Closing. Will reopen with a proper description.

@susodapop susodapop closed this Sep 29, 2023
@susodapop susodapop mentioned this pull request Sep 29, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rcypher-databricks rcypher-databricks Awaiting requested review from rcypher-databricks rcypher-databricks will be requested when the pull request is marked ready for review rcypher-databricks is a code owner

@yunbodeng-db yunbodeng-db Awaiting requested review from yunbodeng-db yunbodeng-db will be requested when the pull request is marked ready for review yunbodeng-db is a code owner

@andrefurlan-db andrefurlan-db Awaiting requested review from andrefurlan-db andrefurlan-db will be requested when the pull request is marked ready for review andrefurlan-db is a code owner

@jackyhu-db jackyhu-db Awaiting requested review from jackyhu-db jackyhu-db will be requested when the pull request is marked ready for review jackyhu-db is a code owner

@benc-db benc-db Awaiting requested review from benc-db benc-db will be requested when the pull request is marked ready for review benc-db is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@susodapop