Main synced to 118.0.3 #40
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We have already de-facto done it since some of the code after the migration to UP requires API level 24.
Just some quick helpful tips.
Slight cleanup.
…ive-webrtc#1376) * Update android_ci.yml * Update ios_ci.yml
d3ce72d android: enable GCM ciphers by default ( Saúl Ibarra Corretgé 2023-05-15 22:03:45 +0200) 65905d0 ios: enable GCM ciphers by default ( Saúl Ibarra Corretgé 2023-05-15 21:31:38 +0200) e38f779 ci: Prevent compile tests when markdown files are altered. (react-native-webrtc#1376) ( Johnathon Weaver 2023-05-11 20:45:28 +0800) ec92186 Update README.md ( Johnathon Weaver 2023-05-11 00:39:07 +0800) 7c6189a Update ISSUE_TEMPLATE.md ( Johnathon Weaver 2023-05-11 00:24:08 +0800) 4f837d0 android: bump API level to 24, aka Android 7 ( Saúl Ibarra Corretgé 2023-05-01 10:35:04 +0200) be1ef90 misc: simplify code formatting script ( Saúl Ibarra Corretgé 2023-04-17 14:00:06 +0200) 6e20800 ios: update dummy framerate value ( davidliu 2023-04-14 02:01:32 +0900) 220b8fd docs: Update README.md ( Johnathon Weaver 2023-04-04 22:38:16 +0800) b418892 docs: Update README.md ( Johnathon Weaver 2023-04-04 22:30:00 +0800) b25e9ea doc: update README ( Saúl Ibarra Corretgé 2023-04-04 15:15:09 +0200)
~~~ "main" tid=1 Waiting at jdk.internal.misc.Unsafe.park (Native method) at java.util.concurrent.locks.LockSupport.park (LockSupport.java:194) at java.util.concurrent.locks.AbstractQueuedSynchronizer.parkAndCheckInterrupt (AbstractQueuedSynchronizer.java:885) at java.util.concurrent.locks.AbstractQueuedSynchronizer.doAcquireSharedInterruptibly (AbstractQueuedSynchronizer.java:1039) at java.util.concurrent.locks.AbstractQueuedSynchronizer.acquireSharedInterruptibly (AbstractQueuedSynchronizer.java:1345) at java.util.concurrent.CountDownLatch.await (CountDownLatch.java:232) at org.webrtc.ThreadUtils$2.run (ThreadUtils.java:1) at org.webrtc.ThreadUtils.executeUninterruptibly (ThreadUtils.java:1) at org.webrtc.ThreadUtils.awaitUninterruptibly (ThreadUtils.java:1) at org.webrtc.ThreadUtils.invokeAtFrontUninterruptibly (ThreadUtils.java:8) at org.webrtc.ThreadUtils.invokeAtFrontUninterruptibly (ThreadUtils.java:16) at org.webrtc.ScreenCapturerAndroid.changeCaptureFormat (ScreenCapturerAndroid.java:6) at com.oney.WebRTCModule.x$a.onOrientationChanged (ScreenCaptureController.java:4) at android.view.OrientationEventListener$SensorEventListenerImpl.onSensorChanged (OrientationEventListener.java:166) at android.hardware.SystemSensorManager$SensorEventQueue.dispatchSensorEvent (SystemSensorManager.java:968) at android.hardware.SystemSensorManager$SensorEventQueue.dispatchSensorEvent (SystemSensorManager.java:900) at android.os.MessageQueue.nativePollOnce (Native method) at android.os.MessageQueue.next (MessageQueue.java:339) at android.os.Looper.loopOnce (Looper.java:186) at android.os.Looper.loop (Looper.java:351) at android.app.ActivityThread.main (ActivityThread.java:8380) at java.lang.reflect.Method.invoke (Native method) at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run (RuntimeInit.java:584) at com.android.internal.os.ZygoteInit.main (ZygoteInit.java:1013) ~~~
We ignore them in the JS layer. It just defaults to ''.
They may create new transceivers, so make sure we create the corresponding JS objects. Fixes: react-native-webrtc#1353 Ref: react-native-webrtc#1375
53e14b4 pc: fix handling legacy options in createOffer ( Saúl Ibarra Corretgé 2023-06-30 22:40:24 +0200) 4465d5a gum: don't pass any track label ( Saúl Ibarra Corretgé 2023-06-12 13:57:07 +0200) b504754 media-stream: make id and active properties readonly ( Saúl Ibarra Corretgé 2023-06-12 11:50:26 +0200) 0ba7d0d android: fix ANR when attaching / detaching tracks ( Saúl Ibarra Corretgé 2023-06-09 11:21:39 +0200) 61629e2 android: fix ANR when handling rotation changes ( Saúl Ibarra Corretgé 2023-06-09 09:43:18 +0200)
We were inadvertently skipping transceivers with currentDirection set tu null, which will be the case for those which were added before sLD was called. Fixes: react-native-webrtc#1404
f3a0ccb log: only enable the rn-webrtc logger automatically ( Saúl Ibarra Corretgé 2023-07-03 14:43:39 +0200) 123e85d deps: remove no longer needed dependencies ( Saúl Ibarra Corretgé 2023-07-03 10:52:05 +0200) cac9de0 pc: fix not updating transceivers in sLD ( Saúl Ibarra Corretgé 2023-07-03 13:43:27 +0200)
…rtc#1425) Bumps [word-wrap](https://github.com/jonschlinkert/word-wrap) from 1.2.3 to 1.2.4. - [Release notes](https://github.com/jonschlinkert/word-wrap/releases) - [Commits](jonschlinkert/word-wrap@1.2.3...1.2.4) --- updated-dependencies: - dependency-name: word-wrap dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Android is using `INACTIVE` rather than `SEND_RECV` as the default transceiver direction. Simple change to resolve the issue and put things inline with iOS and spec.
…ive-webrtc#1433) * feat(Typescripted): ✨ Add type to MediaStreamTrackEvent Define MediaStreamTrackEvent's type and applied using ts guideline on event-target-shim * feat(Typescripted): ✨ Add type to basic RTCEvent * feat(Typescripted): ✨ Add PeerConnection related event type * feat(Typescripted): ✨ Add type to RTCPeerConnection and RTCDataChannel dispatcher * fix(Linting): 🔧 Fixed lint error * feat(Typescripts): 🏷️ Reinforce event string type addEventListener and dispatcher will accept only defined typed * docs(Typescripts): 📝 Add Documentation' Add TSDoc on event related type --------- Co-authored-by: Kuranasaki <[email protected]>
…c#1443) * Improve typing of RTCIceCandidate. * Allow not defining sdpMLineIndex and sdpMid in the constructor parameter. * Typing fo rMediaStream constructor. * Lint fixes. * In the end, the needed change is very small. Roll back to change as little as necessary. --------- Co-authored-by: Antti <[email protected]>
Co-authored-by: Pablo Betancurt <[email protected]>
Fixed an oopsie with the supported feature list.
Slight changes, hopefully easier to read/understand.
It should usually only trigger for bugs in the library, but things will break in very weird ways otherwise. Ref: react-native-webrtc#1453
It doesn't make sense to have streamURL as undefined but it is common to render the RTCView with an undefined variable for the stream before having an actual active stream.
- Make sure the `urls` property is used, while supporting the deprecated `url`. - Make sure all servers are lower-case since the C++ layer does a case insensitive parse. Fixes: react-native-webrtc#1476
It may take a bit for the underlying source to come through, but we have no mechanism to sync the state.
1fc8c29 android: make sure local track's starting readyState is live ( Saúl Ibarra Corretgé 2024-01-16 12:33:27 +0100) f8580c4 dc: send open event after datachannel event ( Saúl Ibarra Corretgé 2024-01-12 09:31:05 +0100) 6a48e02 doc: add link to Unified Plan migration document ( Saúl Ibarra Corretgé 2024-01-08 11:55:19 +0100) 039bee9 android: add UVC Camera support ( Tommi Ilmonen 2023-12-18 14:50:53 +0200) 871c465 Update README.md - Correct WebRTC Revision - M118 ( Johnathon Weaver 2023-11-28 00:56:13 +0800)
With target API 34 (that is, Android 14) the foreground service requirements are quite tight. So tight in fact that it's not possible to perform the necessary operations in order unless we do so from native code. This commit adds an optional media projecttion service to that end.
9e7ccc8 android: add media projection service ( Calinteodor 2024-02-29 14:55:05 +0200) 50a51c1 docs: Add foreground service type perms to android docs (react-native-webrtc#1509) ( davidliu 2024-02-23 18:39:51 +0900)
e00ade9 android: disable UVC enumerator on Android 14 ( Saúl Ibarra Corretgé 2024-03-12 11:24:17 +0100) 0d26e90 android: use libwebrtc getStats for RtpReceiver and RtpSender (react-native-webrtc#1516) ( davidliu 2024-03-12 15:00:59 +0900)
# Conflicts: # README.md # ios/RCTWebRTC/WebRTCModule+RTCMediaStream.m # package-lock.json # package.json # src/MediaDevices.ts
1 task
|
Not quite sure how to review this. If it works, it works! |
kompfner
approved these changes
Mar 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Latest version of react-native-webrtc, which is using webrtc 118.