-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BUG: Compatibility with Expo 50 #48
Comments
Thank you for reporting this @hramos. We have a task in our backlog to integrate the latest changes from I will let you know as soon as we introduce these updates. |
Thank you @filipi87 - I've built a project on Expo 50 and just ran into this today, patiently waiting on a fix :) . In the meantime is the recommended solution to revert back to Expo version 49? |
Yes, I think keep using Expo 49 would be the best approach for now. 👍 |
Any clear timeline on this? |
Hi, @nsjames; this is still something we're working on. The recommendation is not to upgrade Expo in the meantime. |
Thank you for the update @jamsea - Our team has built our app using Expo 50 and Expo Router v3 features, so downgrading to Expo 49 is not a viable option for us and is likely not an option for others, either. This does currently block us from progressing. In the meantime we are sending mobile users to the hosted Daily room, but we really need native functionality since our service centers around video calls |
In my case, I didn't upgrade. Expo projects start at 50 from quickstart now. |
Hi, I have already an open PR to integrate the latest changes from Once that is merged, we should be able to add support for Expo 50 in our next |
The PR with the webrtc changes has already been merged, and we already have PRs up for both:
They are just waiting for |
We are now supporting Expo 50. You will need to use the latest version of our You can also check this daily-demos/daily-expo-demo#6, where we changed our demo app to use Expo 50. |
Expected behavior
We're currently using Daily with Expo SDK 49 in a React Native app. When upgrading to Expo SDK 50, I am seeing a red screen / error which appears to be due to an outdated
react-native-webrtc
dependency.The goal of this issue is to track any blockers preventing React Native apps that use Daily from upgrading their Expo dependency to version 50.
@daily-co/[email protected]
to use version 118.0.1 ofreact-native-webrtc
.Describe the bug (unexpected behavior)
When a
<DailyMediaView />
is rendered, the React Native app throws up a red screen / error:...with the following logged to the console:
This seems to point to an issue with WebRTC. After some digging, I found a potential dependency mismatch with the
@config-plugins/react-native-webrtc
config plugin which is used to configurereact-native-webrtc
in Expo projects.According to https://www.npmjs.com/package/@config-plugins/react-native-webrtc, Expo SDK 50 requires
@config-plugins/[email protected]
, which itself requires[email protected]
.In the case of
@daily-co/react-native-daily-js
, it has a dependency on@daily-co/[email protected]
, which is a fork of[email protected]
.In short, it looks like the fork needs to be updated to be based off a newer version of the
react-native-webrtc
package.Steps to reproduce
npx create-expo-app SampleApp
<DailyMediaView />
Screenshots
See above.
System information
Additional context
The text was updated successfully, but these errors were encountered: