chore(deps): update dependency rimraf to v5.0.10

[gweesin]

• Closes Update to rimraf 4.0.0 or later #30148

Additional details

Steps to test

cd npm/puppeteer

# generate dist
yarn build

# remove dist and generate dist
yarn build

the same as /errors/, /runner/ dir

How has the user experience changed?

No change.

PR Tasks

• Have tests been added/updated?
• Has a PR for user-facing changes been opened in cypress-documentation?
• Have API changes been updated in the type definitions?

[CLAassistant]

All committers have signed the CLA.

[cypress-app-bot]

• Create a Draft Pull Request if your PR is not ready for review. Mark the PR as Ready for Review when you're ready for a Cypress team member to review the PR.

[MikeMcC399]

@gweesin

There are breaking changes for rimraf from v3 -> v4 -> v5 which need to be accounted for, see https://github.com/isaacs/rimraf/blob/v5.0.10/README.md

The following build command using gulp fails:

yarn workspace @packages/extension build

@packages/extension: [00:00:59] Using gulpfile ~/cypress/packages/extension/gulpfile.ts
@packages/extension: [00:00:59] Starting 'build'...
@packages/extension: [00:00:59] Starting 'clean'...
@packages/extension: [00:00:59] 'clean' errored after 1.15 ms
@packages/extension: [00:00:59] Error: invalid rimraf options
@packages/extension:     at assertRimrafOptions (/root/cypress/node_modules/rimraf/src/opt-arg.ts:23:11)
@packages/extension:     at optArgT (/root/cypress/node_modules/rimraf/src/opt-arg.ts:54:22)
@packages/extension:     at optArg (/root/cypress/node_modules/rimraf/src/opt-arg.ts:82:57)
@packages/extension:     at /root/cypress/node_modules/rimraf/src/index.ts:30:27
@packages/extension:     at clean (/root/cypress/packages/extension/gulpfile.ts:16:9)
@packages/extension:     at bound (node:domain:433:15)
@packages/extension:     at runBound (node:domain:444:12)
@packages/extension:     at asyncRunner (/root/cypress/node_modules/async-done/index.js:55:18)
@packages/extension:     at processTicksAndRejections (node:internal/process/task_queues:77:11)
@packages/extension: [00:00:59] 'build' errored after 8.37 ms

So this means that the following would need to be changed:

cypress/packages/extension/gulpfile.ts

Lines 15 to 17 in 195cdb1

	const clean = (done) => {
	rimraf('dist', done)
	}

[jennifer-shehane]

Running the tests

[gweesin]

Running the tests

I'm sorry my tests running blocked because of my Windows OS(#30157)

[jennifer-shehane]

@gweesin Can you address the comment left to refactor the code here?

[gweesin]

@gweesin Can you address the comment left to refactor the code here?

Of course. I never use gulp before, so I'm curious if it's possible to receive a Promise instead of callback function. I will try it later

[ryanthemanuel]

@gweesin Can you address the comment left to refactor the code here?

Of course. I never use gulp before, so I'm curious if it's possible to receive a Promise instead of callback function. I will try it later

@gweesin, Here's the relevant gulp documentation on async functions if you're curious to learn more about it: https://gulpjs.com/docs/en/getting-started/async-completion/#using-asyncawait

[gweesin]

@ryanthemanuel thank you, this is really helpful

[gweesin]

@MikeMcC399 Could I assume that devDependencies are not related to users, so they should be classified as chore(deps) rather than dependency?

[MikeMcC399]

@gweesin

My apologies! 🤭 I ran yarn binary-build on your branch and it left rimraf at version 3.0.2, so your commit message is correct.
Please disregard my question about this and I will hide it as "resolved".

Edit: This is caused by

cypress/npm/webpack-dev-server/package.json

Line 28 in b6b0b49

"webpack-dev-server": "^4.15.2",

as [email protected] has a dependency on "rimraf": "^3.0.2"

[cypress-bot]

Released in 13.15.0.

This comment thread has been locked. If you are still experiencing this issue after upgrading to
Cypress v13.15.0, please open a new issue.