Skip to content

Commit

Permalink
chore(deps): update dependency rimraf to v5.0.10 (#30155)
Browse files Browse the repository at this point in the history
* chore(deps): update dependency rimraf to v5.0.10

* fix: fix clean errors caused by rimraf breaking change

* refactor: use promise instead of callback

---------

Co-authored-by: Ryan Manuel <[email protected]>
  • Loading branch information
gweesin and ryanthemanuel authored Sep 5, 2024
1 parent d067b7e commit 7337927
Show file tree
Hide file tree
Showing 8 changed files with 17 additions and 26 deletions.
2 changes: 1 addition & 1 deletion guides/writing-cross-platform-javascript.md
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@ This will stop developers on Windows from running `yarn clean` unless they are s
```json
{
"devDependencies": {
"rimraf": "3.0.2",
"rimraf": "5.0.10"
},
"scripts": {
"clean": "rimraf '**/*.js'"
Expand Down
2 changes: 1 addition & 1 deletion npm/puppeteer/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@
"chokidar": "^3.5.3",
"express": "4.19.2",
"mocha": "^9.2.2",
"rimraf": "^5.0.1",
"rimraf": "^5.0.10",
"semantic-release": "22.0.12",
"sinon": "^13.0.1",
"sinon-chai": "^3.7.0",
Expand Down
3 changes: 1 addition & 2 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -115,7 +115,6 @@
"@types/react": "16.9.50",
"@types/react-dom": "16.9.8",
"@types/request-promise": "4.1.45",
"@types/rimraf": "^3.0.2",
"@types/send": "^0.17.1",
"@types/sinon-chai": "3.2.3",
"@types/through2": "^2.0.36",
Expand Down Expand Up @@ -187,7 +186,7 @@
"pluralize": "8.0.0",
"print-arch": "1.0.0",
"proxyquire": "2.1.3",
"rimraf": "3.0.2",
"rimraf": "5.0.10",
"semantic-release": "22.0.12",
"semantic-release-monorepo": "8.0.2",
"semver": "7.5.3",
Expand Down
2 changes: 1 addition & 1 deletion packages/errors/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@
"is-ci": "^3.0.1",
"mocha": "7.0.1",
"pngjs": "^6.0.0",
"rimraf": "3.0.2",
"rimraf": "5.0.10",
"sinon": "7.5.0",
"terminal-banner": "^1.1.0",
"xvfb-maybe": "^0.2.1"
Expand Down
6 changes: 3 additions & 3 deletions packages/extension/gulpfile.ts
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import gulp from 'gulp'
import rimraf from 'rimraf'
import { rimraf } from 'rimraf'
import { waitUntilIconsBuilt } from '../../scripts/ensure-icons'
import cp from 'child_process'
import * as path from 'path'
Expand All @@ -12,8 +12,8 @@ async function cypressIcons () {
return require('@packages/icons')
}

const clean = (done) => {
rimraf('dist', done)
function clean (): Promise<boolean> {
return rimraf('dist')
}

const manifest = (v: 'v2' | 'v3') => {
Expand Down
2 changes: 1 addition & 1 deletion packages/runner/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@
"babel-plugin-prismjs": "1.0.2",
"bluebird": "3.5.3",
"cross-env": "6.0.3",
"rimraf": "^5.0.1",
"rimraf": "^5.0.10",
"webpack": "^5.88.2",
"webpack-cli": "^5.1.4"
},
Expand Down
4 changes: 2 additions & 2 deletions scripts/gulp/tasks/gulpMakePackage.ts
Original file line number Diff line number Diff line change
Expand Up @@ -71,12 +71,12 @@ export async function makePackage () {
files: ['src'],
dependencies: {},
devDependencies: results.scaffoldTests ? {
'rimraf': '3.0.2',
'rimraf': '5.0.10',
'mocha': '7.0.1',
'chai': '4.2.0',
'@packages/ts': '0.0.0-development',
} : {
'rimraf': '3.0.2',
'rimraf': '5.0.10',
'@packages/ts': '0.0.0-development',
},
},
Expand Down
22 changes: 7 additions & 15 deletions yarn.lock
Original file line number Diff line number Diff line change
Expand Up @@ -7917,14 +7917,6 @@
resolved "https://registry.yarnpkg.com/@types/retry/-/retry-0.12.2.tgz#ed279a64fa438bb69f2480eda44937912bb7480a"
integrity sha512-XISRgDJ2Tc5q4TRqvgJtzsRkFYNJzZrhTdtMoGVBttwzzQJkPnS3WWTFc7kuDRoPtPakl+T+OfdEUjYJj7Jbow==

"@types/rimraf@^3.0.2":
version "3.0.2"
resolved "https://registry.yarnpkg.com/@types/rimraf/-/rimraf-3.0.2.tgz#a63d175b331748e5220ad48c901d7bbf1f44eef8"
integrity sha512-F3OznnSLAUxFrCEu/L5PY8+ny8DtcFRjx7fZZ9bycvXRi3KPTRS9HOitGZwvPg0juRhXFWIeKX58cnX5YqLohQ==
dependencies:
"@types/glob" "*"
"@types/node" "*"

"@types/[email protected]":
version "7.5.0"
resolved "https://registry.yarnpkg.com/@types/semver/-/semver-7.5.0.tgz#591c1ce3a702c45ee15f47a42ade72c2fd78978a"
Expand Down Expand Up @@ -26958,20 +26950,20 @@ [email protected], rimraf@^3.0.2:
dependencies:
glob "^7.1.3"

[email protected], rimraf@^5.0.10, rimraf@^5.0.5:
version "5.0.10"
resolved "https://registry.npmmirror.com/rimraf/-/rimraf-5.0.10.tgz#23b9843d3dc92db71f96e1a2ce92e39fd2a8221c"
integrity sha512-l0OE8wL34P4nJH/H2ffoaniAokM2qSmrtXHmlpvYr5AVVX8msAyW0l8NVJFDxlSK4u3Uh/f41cQheDVdnYijwQ==
dependencies:
glob "^10.3.7"

rimraf@^4.4.1:
version "4.4.1"
resolved "https://registry.yarnpkg.com/rimraf/-/rimraf-4.4.1.tgz#bd33364f67021c5b79e93d7f4fa0568c7c21b755"
integrity sha512-Gk8NlF062+T9CqNGn6h4tls3k6T1+/nXdOcSZVikNVtlRdYpA7wRJJMoXmuvOnLW844rPjdQ7JgXCYM6PPC/og==
dependencies:
glob "^9.2.0"

rimraf@^5.0.1, rimraf@^5.0.5:
version "5.0.5"
resolved "https://registry.yarnpkg.com/rimraf/-/rimraf-5.0.5.tgz#9be65d2d6e683447d2e9013da2bf451139a61ccf"
integrity sha512-CqDakW+hMe/Bz202FPEymy68P+G50RfMQK+Qo5YUqc9SPipvbGjCGKd0RSKEelbsfQuw3g5NZDSrlZZAJurH1A==
dependencies:
glob "^10.3.7"

ripemd160@^2.0.0, ripemd160@^2.0.1:
version "2.0.2"
resolved "https://registry.yarnpkg.com/ripemd160/-/ripemd160-2.0.2.tgz#a1c1a6f624751577ba5d07914cbc92850585890c"
Expand Down

5 comments on commit 7337927

@cypress-bot
Copy link
Contributor

@cypress-bot cypress-bot bot commented on 7337927 Sep 5, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Circle has built the linux arm64 version of the Test Runner.

Learn more about this pre-release build at https://on.cypress.io/advanced-installation#Install-pre-release-version

Run this command to install the pre-release locally:

npm install https://cdn.cypress.io/beta/npm/13.14.3/linux-arm64/develop-7337927a74586f38b4d48d02bd59c7e957e11625/cypress.tgz

@cypress-bot
Copy link
Contributor

@cypress-bot cypress-bot bot commented on 7337927 Sep 5, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Circle has built the linux x64 version of the Test Runner.

Learn more about this pre-release build at https://on.cypress.io/advanced-installation#Install-pre-release-version

Run this command to install the pre-release locally:

npm install https://cdn.cypress.io/beta/npm/13.14.3/linux-x64/develop-7337927a74586f38b4d48d02bd59c7e957e11625/cypress.tgz

@cypress-bot
Copy link
Contributor

@cypress-bot cypress-bot bot commented on 7337927 Sep 5, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Circle has built the win32 x64 version of the Test Runner.

Learn more about this pre-release build at https://on.cypress.io/advanced-installation#Install-pre-release-version

Run this command to install the pre-release locally:

npm install https://cdn.cypress.io/beta/npm/13.14.3/win32-x64/develop-7337927a74586f38b4d48d02bd59c7e957e11625/cypress.tgz

@cypress-bot
Copy link
Contributor

@cypress-bot cypress-bot bot commented on 7337927 Sep 5, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Circle has built the darwin arm64 version of the Test Runner.

Learn more about this pre-release build at https://on.cypress.io/advanced-installation#Install-pre-release-version

Run this command to install the pre-release locally:

npm install https://cdn.cypress.io/beta/npm/13.14.3/darwin-arm64/develop-7337927a74586f38b4d48d02bd59c7e957e11625/cypress.tgz

@cypress-bot
Copy link
Contributor

@cypress-bot cypress-bot bot commented on 7337927 Sep 5, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Circle has built the darwin x64 version of the Test Runner.

Learn more about this pre-release build at https://on.cypress.io/advanced-installation#Install-pre-release-version

Run this command to install the pre-release locally:

npm install https://cdn.cypress.io/beta/npm/13.14.3/darwin-x64/develop-7337927a74586f38b4d48d02bd59c7e957e11625/cypress.tgz

Please sign in to comment.