Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add basic facilities for 3D background irfs #276

Open
wants to merge 52 commits into
base: main
Choose a base branch
from

Should now support rectangular arrays

7c6d158
Select commit
Loading
Failed to load commit list.
Open

Add basic facilities for 3D background irfs #276

Should now support rectangular arrays
7c6d158
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project failed Jul 18, 2024 in 0s

94.83% (-0.78%) compared to cb92eef

View this Pull Request on Codecov

94.83% (-0.78%) compared to cb92eef

Details

Codecov Report

Attention: Patch coverage is 15.62500% with 27 lines in your changes missing coverage. Please review.

Project coverage is 94.83%. Comparing base (cb92eef) to head (7c6d158).
Report is 11 commits behind head on main.

Files Patch % Lines
pyirf/io/gadf.py 12.50% 14 Missing ⚠️
pyirf/irf/background.py 13.33% 13 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #276      +/-   ##
==========================================
- Coverage   95.60%   94.83%   -0.78%     
==========================================
  Files          62       62              
  Lines        3278     3308      +30     
==========================================
+ Hits         3134     3137       +3     
- Misses        144      171      +27     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.