Add basic facilities for 3D background irfs #276
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #276 +/- ##
==========================================
- Coverage 95.60% 94.83% -0.78%
==========================================
Files 62 62
Lines 3278 3308 +30
==========================================
+ Hits 3134 3137 +3
- Misses 144 171 +27 ☔ View full report in Codecov by Sentry. |
maxnoe
reviewed
Jan 16, 2024
| def create_background_3d_hdu( | ||
| background_3d, | ||
| reco_energy_bins, | ||
| fov_offset_bins, |
There was a problem hiding this comment.
should have fov_lon_bins / fov_lat_bins
maxnoe
reviewed
Jan 16, 2024
| background_3d, | ||
| reco_energy_bins, | ||
| fov_offset_bins, | ||
| extname="BACKGROUND", |
maxnoe
reviewed
Jan 16, 2024
| header["HDUCLAS2"] = "BKG" | ||
| header["HDUCLAS3"] = "FULL-ENCLOSURE" | ||
| header["HDUCLAS4"] = "BKG_2D" | ||
| header["FOVALIGN"] = "ALTAZ" |
There was a problem hiding this comment.
This should be an argument, not hard-coded
Merged
maxnoe
reviewed
Feb 19, 2024
pyirf/irf/background.py
Outdated
| per_energy = (hist.T / bin_width_energy).T | ||
|
|
||
| # divide by solid angle in each fov bin and the observation time | ||
| bin_solid_angle = np.diff(fov_offset_bins) |
Remove compatibility pins
Add 2023 ICRC paper to README
maxnoe
reviewed
Nov 8, 2024
maxnoe
reviewed
Nov 8, 2024
maxnoe
reviewed
Nov 8, 2024
maxnoe
reviewed
Nov 8, 2024
maxnoe
reviewed
Nov 8, 2024
maxnoe
reviewed
Nov 8, 2024
maxnoe
reviewed
Nov 8, 2024
…ensions The different methods use binning in different coordinate systems - effective_area_3D_polar uses a polar coordinate system with radial FOV offset and azimuthal FOV position angle bins - effective_area_3D_nominal uses a nominal coordinate system with FOV longitude and FOV latitude bins
These calculate the number of showers in each bin for different coordinate systems - calculate_n_showers_3D_polar uses a polar coordinate system with radial FOV offset bins and azimuthal FOV position angle bins - calculate_n_showers_3D_nominal uses a nominal coordinate system with FOV longitude and latitude bins
Remove stale debugging code Add news fragment Update energy_dispersion_to_migration - divide by the migration bin widths before resampling - minor style and format changes Fix pdf conversion to probability, remove final norm
Simplify normalization code for migra matrix
update unit test
Fix test_energy_dispersion_to_migration
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add functions for making a 3D background using square bins, this requires that the event tables have the two columns
reco_fov_latandreco_fov_lon.