Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Better management of realtime with contacts #334

Open
wants to merge 10 commits into
base: master
Choose a base branch
from
Open

Better management of realtime with contacts #334

wants to merge 10 commits into from

Commits on Nov 15, 2024

  1. fix: Rename contacts query 

    New name more precisely show that we only fetch me and favorites.
    @zatteo
    zatteo committed Nov 15, 2024
    Configuration menu
    Copy the full SHA
    34226bd View commit details
    Browse the repository at this point in the history

  2. refactor: Upsert contact data in a private typed method

    @zatteo
    zatteo committed Nov 15, 2024
    Configuration menu
    Copy the full SHA
    dbd283e View commit details
    Browse the repository at this point in the history

  3. feat: Add contact from realtime only if we should 

    It was possible to add a contact in the browser extension from
realtime even if we did not want it in the browser extension.
    @zatteo
    zatteo committed Nov 15, 2024
    Configuration menu
    Copy the full SHA
    432918e View commit details
    Browse the repository at this point in the history

  4. feat: Update contact from realtime only if we should

    @zatteo
    zatteo committed Nov 15, 2024
    Configuration menu
    Copy the full SHA
    9cb81ae View commit details
    Browse the repository at this point in the history

  5. refactor: Create a method that fetch an hydrated paper 

    => a paper with potential contact inside
    @zatteo
    zatteo committed Nov 15, 2024
    Configuration menu
    Copy the full SHA
    37ac6cf View commit details
    Browse the repository at this point in the history

  6. refactor: Pass directly paper instead of paperId

    @zatteo
    zatteo committed Nov 15, 2024
    Configuration menu
    Copy the full SHA
    512008e View commit details
    Browse the repository at this point in the history

  7. feat: Manage correctly contacts when a paper is updated from realtime

    @zatteo
    zatteo committed Nov 15, 2024
    Configuration menu
    Copy the full SHA
    c2c5200 View commit details
    Browse the repository at this point in the history

  8. style: Prettier

    @zatteo
    zatteo committed Nov 15, 2024
    Configuration menu
    Copy the full SHA
    6b9d10f View commit details
    Browse the repository at this point in the history

  9. fix: Use correctly optional chaining to get me 

    me[0] should exist here because every one has me. But after we should use it until the end.
    @zatteo
    zatteo committed Nov 15, 2024
    Configuration menu
    Copy the full SHA
    7705380 View commit details
    Browse the repository at this point in the history

  10. feat: Remove special case for "me" update 

    I had to start with a special case for "me" update, because in Cozy
Contacts, relations were stored only in the contact who created the
relation.

So when "me" was updated, a relation of me could have been deleted,
and it was impossible to know which one easily, so it was impossible
to know if the contact should be removed from the extension.

With cozy/cozy-contacts#1020, relations are
propagated to the target contact.

So we will get a realtime event and we will be able to check if the
contact must be displayed or not without any special case.
    @zatteo
    zatteo committed Nov 15, 2024
    Configuration menu
    Copy the full SHA
    3c915eb View commit details
    Browse the repository at this point in the history