Better management of realtime with contacts #334
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zatteo
changed the title
zatteo
force-pushed
the
fix/contacts-displayed-realtime
branch
2 times, most recently
from
606b7d8
to
202505e
Compare
Merkur39
reviewed
Nov 15, 2024
libs/cozy/queries.ts
Outdated
| definition: Q(CONTACTS_DOCTYPE).where({ me: true }), | ||
| options: { | ||
| as: `${CONTACTS_DOCTYPE}/myself`, | ||
| singleDocData: true, |
There was a problem hiding this comment.
Le singleDocData est inutile ici je pense, il ne marche qu'avec .getById
libs/cozy/queries.ts
Outdated
| export const fetchMyself = async (client: CozyClient): Promise<IOCozyContact> => { | ||
| const myselfQuery = buildMyselfQuery(); | ||
|
|
||
| const { data }: { data: IOCozyContact } = await client.query( |
libs/cozy/sync.ts
Outdated
|
|
||
| const contactRelatedToMe = | ||
| // @ts-expect-error related added manually with an hydration | ||
| me?.[0]?.relationships?.related?.data.find((relatedContact) => relatedContact._id === contact._id); |
There was a problem hiding this comment.
me?.l'opérateur optionnel ne devrait pas être nécessaire ici, si ? Et il manque entre data.find
Comment on lines
78
to
86
| if (data.me) { | ||
| // We need to do a fullSync here because we have no other way to know | ||
| // if a contact related to me was removed of the me relation | ||
| this.logService.info(`Starting full sync from realtime because me`) | ||
|
|
||
| await dispatchUpdate(this.client, "io.cozy.contacts", data as CouchDBDocument); | ||
| this.messagingService.send("fullSync"); | ||
|
|
||
| return; | ||
| } |
There was a problem hiding this comment.
Waiting new PR from cozy-contacts
New name more precisely show that we only fetch me and favorites.
It was possible to add a contact in the browser extension from realtime even if we did not want it in the browser extension.
=> a paper with potential contact inside
me[0] should exist here because every one has me. But after we should use it until the end.
I had to start with a special case for "me" update, because in Cozy Contacts, relations were stored only in the contact who created the relation. So when "me" was updated, a relation of me could have been deleted, and it was impossible to know which one easily, so it was impossible to know if the contact should be removed from the extension. With cozy/cozy-contacts#1020, relations are propagated to the target contact. So we will get a realtime event and we will be able to check if the contact must be displayed or not without any special case.
zatteo
force-pushed
the
fix/contacts-displayed-realtime
branch
from
202505e
to
3c915eb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.